From: Viresh Kumar <viresh.kumar@linaro.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Stephan Gerhold <stephan@gerhold.net>,
Ulf Hansson <ulf.hansson@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Stephen Boyd <sboyd@kernel.org>, Nishanth Menon <nm@ti.com>,
nks@flawful.org, Georgi Djakov <georgi.djakov@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Wolfram Sang <wsa@the-dreams.de>,
Linux I2C <linux-i2c@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH V2 2/2] cpufreq: dt: Refactor initialization to handle probe deferral properly
Date: Fri, 16 Oct 2020 10:33:47 +0530 [thread overview]
Message-ID: <20201016050347.ers54itzmxgijzsy@vireshk-i7> (raw)
In-Reply-To: <CAMuHMdVAJdHVMtK3Sc4sJiJGAwz1J4dKODBFcNzgstaktyKkOw@mail.gmail.com>
On 14-10-20, 18:40, Geert Uytterhoeven wrote:
> On this platform (r8a7791-koelsch.dts), there is no opp table in DT.
>
> Before:
I assume this means before this patchset came in..
> boot:
> cpufreq-dt cpufreq-dt: dt_cpufreq_probe:362
> cpu cpu0: resources_available:95
> cpu cpu0: resources_available:102: clk_get() returned z
> cpu cpu0: resources_available:120:
> dev_pm_opp_of_find_icc_paths() returned 0
> cpu cpu0: resources_available:125: find_supply_name() returned cpu0
> cpu cpu0: resources_available:132: regulator_get_optional()
> returned -EPROBE_DEFER
> cpu cpu0: cpu0 regulator not ready, retry
> cpufreq-dt cpufreq-dt: dt_cpufreq_probe:371:
> resources_available() returned -517
we deferred probe once.
> ...
> cpufreq-dt cpufreq-dt: dt_cpufreq_probe:362
> cpu cpu0: resources_available:95
> cpu cpu0: resources_available:102: clk_get() returned z
> cpu cpu0: resources_available:120:
> dev_pm_opp_of_find_icc_paths() returned 0
> cpu cpu0: resources_available:125: find_supply_name() returned cpu0
> cpu cpu0: resources_available:132: regulator_get_optional()
> returned (ptrval)
found regulator next time.
> cpufreq-dt cpufreq-dt: dt_cpufreq_probe:371:
> resources_available() returned 0
> cpufreq-dt cpufreq-dt: dt_cpufreq_probe:375
> cpufreq_dt: cpufreq_init:162
> cpu cpu0: cpufreq_init:170: clk_get() returned z
> cpu cpu0: cpufreq_init:179: dev_pm_opp_of_get_sharing_cpus() returned -2
> cpu cpu0: cpufreq_init:198: find_supply_name() returned cpu0
> <i2c comm>
> cpu cpu0: cpufreq_init:201: dev_pm_opp_set_regulators() returned (ptrval)
> <i2c comm>
> cpu cpu0: cpufreq_init:230: dev_pm_opp_of_cpumask_add_table() returned 0
> cpu cpu0: cpufreq_init:239: dev_pm_opp_get_opp_count() returned 0
> cpu cpu0: OPP table is not ready, deferring probe
This failed, as we couldn't have deferred probe from cpufreq_init.
Which means that cpufreq didn't work here.
> cpufreq_dt: cpufreq_init:162
> cpu cpu1: cpufreq_init:170: clk_get() returned z
> cpu cpu1: cpufreq_init:179: dev_pm_opp_of_get_sharing_cpus() returned -2
> cpu cpu1: no regulator for cpu1
> cpu cpu1: cpufreq_init:198: find_supply_name() returned (null)
> cpu cpu1: cpufreq_init:230: dev_pm_opp_of_cpumask_add_table() returned 0
> cpu cpu1: cpufreq_init:239: dev_pm_opp_get_opp_count() returned 0
> cpu cpu1: OPP table is not ready, deferring probe
Same for CPU1.
>
> s2ram:
> cpufreq_dt: cpufreq_init:162
> cpu cpu1: cpufreq_init:170: clk_get() returned z
> cpu cpu1: cpufreq_init:179: dev_pm_opp_of_get_sharing_cpus() returned -2
> cpu cpu1: no regulator for cpu1
> cpu cpu1: cpufreq_init:198: find_supply_name() returned (null)
> cpu cpu1: cpufreq_init:230: dev_pm_opp_of_cpumask_add_table() returned 0
> cpu cpu1: cpufreq_init:239: dev_pm_opp_get_opp_count() returned 0
> cpu cpu1: OPP table is not ready, deferring probe
And same here.
> CPU1 is up
>
> After:
> boot:
> cpufreq-dt cpufreq-dt: dt_cpufreq_probe:356
> cpufreq_dt: dt_cpufreq_early_init:251
> cpu cpu0: dt_cpufreq_early_init:256
> cpu cpu0: dt_cpufreq_early_init:271: dev_pm_opp_get_opp_table()
> returned (ptrval)
> cpu cpu0: dt_cpufreq_early_init:284: find_supply_name() returned cpu0
> cpu cpu0: dt_cpufreq_early_init:288: dev_pm_opp_set_regulators()
> returned -EPROBE_DEFER
> cpufreq-dt cpufreq-dt: dt_cpufreq_probe:360:
> dt_cpufreq_early_init() returned -517
> ...
> cpufreq-dt cpufreq-dt: dt_cpufreq_probe:356
> cpufreq_dt: dt_cpufreq_early_init:251
> cpu cpu0: dt_cpufreq_early_init:256
> cpu cpu0: dt_cpufreq_early_init:271: dev_pm_opp_get_opp_table()
> returned (ptrval)
> cpu cpu0: dt_cpufreq_early_init:284: find_supply_name() returned cpu0
> cpu cpu0: dt_cpufreq_early_init:288: dev_pm_opp_set_regulators()
> returned (ptrval)
> cpu cpu0: dt_cpufreq_early_init:301:
> dev_pm_opp_of_get_sharing_cpus() returned -2
> cpufreq-dt cpufreq-dt: dt_cpufreq_probe:360:
> dt_cpufreq_early_init() returned 0
> cpufreq_dt: dt_cpufreq_early_init:251
> cpufreq-dt cpufreq-dt: dt_cpufreq_probe:360:
> dt_cpufreq_early_init() returned 0
> cpufreq-dt cpufreq-dt: dt_cpufreq_probe:365
> cpufreq_dt: cpufreq_init:114
> cpu cpu0: cpufreq_init:124: clk_get() returned z
> cpu cpu0: cpufreq_init:142: dev_pm_opp_of_cpumask_add_table() returned 0
> cpu cpu0: cpufreq_init:151: dev_pm_opp_get_opp_count() returned 0
> cpu cpu0: OPP table can't be empty
Same issue here.
> cpufreq_dt: cpufreq_init:114
> cpu cpu0: cpufreq_init:124: clk_get() returned z
> <i2c comm>
> cpu cpu0: cpufreq_init:142: dev_pm_opp_of_cpumask_add_table() returned 0
> cpu cpu0: cpufreq_init:151: dev_pm_opp_get_opp_count() returned 0
>
> s2ram:
>
> cpufreq_dt: cpufreq_init:114
> cpu cpu0: cpufreq_init:124: clk_get() returned z
> WARNING: CPU: 1 PID: 14 at drivers/i2c/i2c-core.h:54
> __i2c_transfer+0x2d8/0x310
> i2c i2c-6: Transfer while suspended
> cpu cpu0: cpufreq_init:142: dev_pm_opp_of_cpumask_add_table() returned 0
> cpu cpu0: cpufreq_init:151: dev_pm_opp_get_opp_count() returned 0
> cpu cpu0: OPP table can't be empty
> CPU1 is up
>
> I hope this helps.
Unfortunately it raised more questions than what it answered :(
--
viresh
next prev parent reply other threads:[~2020-10-16 5:03 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 9:09 [PATCH V2 1/2] opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER Viresh Kumar
2020-08-24 9:09 ` [PATCH V2 2/2] cpufreq: dt: Refactor initialization to handle probe deferral properly Viresh Kumar
[not found] ` <CGME20200901085708eucas1p231ccacd7b41685ece92ee21e3b726f28@eucas1p2.samsung.com>
2020-09-01 8:57 ` Marek Szyprowski
2020-09-01 9:45 ` Viresh Kumar
2020-09-01 10:05 ` Marek Szyprowski
2020-09-01 10:12 ` Viresh Kumar
2020-10-13 9:47 ` Geert Uytterhoeven
2020-10-13 9:56 ` Viresh Kumar
2020-10-14 16:40 ` Geert Uytterhoeven
2020-10-16 5:03 ` Viresh Kumar [this message]
2020-10-16 6:44 ` Geert Uytterhoeven
2020-10-16 8:07 ` Viresh Kumar
2020-10-27 16:29 ` Geert Uytterhoeven
2020-10-28 5:48 ` Viresh Kumar
2020-10-28 9:49 ` Geert Uytterhoeven
2020-10-28 9:52 ` Viresh Kumar
2020-08-24 9:17 ` [PATCH V2 1/2] opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER Krzysztof Kozlowski
2020-08-24 11:08 ` Ulf Hansson
2020-08-24 11:39 ` Stephan Gerhold
2020-10-15 18:05 ` Sudeep Holla
2020-10-16 4:24 ` Viresh Kumar
2020-10-16 6:00 ` Sudeep Holla
2020-10-16 11:12 ` Sudeep Holla
2020-10-16 15:28 ` Stephan Gerhold
2020-10-19 4:58 ` Viresh Kumar
2020-10-19 9:17 ` Sudeep Holla
2020-10-19 9:24 ` Viresh Kumar
2020-10-19 10:12 ` Sudeep Holla
2020-10-19 10:35 ` Viresh Kumar
2020-10-19 14:10 ` Sudeep Holla
2020-10-20 5:05 ` Viresh Kumar
2020-10-20 5:54 ` Viresh Kumar
2020-10-20 9:37 ` Sudeep Holla
2020-10-20 9:41 ` Viresh Kumar
2020-10-20 9:52 ` Sudeep Holla
2020-10-20 9:59 ` Viresh Kumar
2020-10-27 22:24 ` Guenter Roeck
2020-10-28 4:06 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016050347.ers54itzmxgijzsy@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=broonie@kernel.org \
--cc=geert@linux-m68k.org \
--cc=georgi.djakov@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=nks@flawful.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@kernel.org \
--cc=stephan@gerhold.net \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).