From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tom Zanussi <zanussi@kernel.org>
Subject: Re: [GIT PULL] tracing: Updates for 5.10
Date: Fri, 16 Oct 2020 13:05:45 +0900 [thread overview]
Message-ID: <20201016130545.caea7a3312ca2ee32990af61@kernel.org> (raw)
In-Reply-To: <20201015235444.6f222746@gandalf.local.home>
On Thu, 15 Oct 2020 23:54:44 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Fri, 16 Oct 2020 11:53:23 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > >
> > > I'll have to think about how to untangle this. Is there some kind of
> > > annotation that makes it show that a path can only be called at boot up and
> > > not later?
> >
> > What happen if we use Peter's static_call() and update it after boot up?
>
> I think that's a bit over engineering ;-)
>
> > Or, we might need to break apart the trace_array_create() and restruct
> > it as __init trace_array_early_create() and trace_array_create().
>
> That will likely make the code a bit more complex and possibly add as much
> code as we save from the __init sections.
>
> I think the best solution is what you proposed, and removing the __init,
> and possibly making that function inline as well.
>
> Care to send an official patch?
Sure, I'll send it.
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2020-10-16 4:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 17:53 [GIT PULL] tracing: Updates for 5.10 Steven Rostedt
2020-10-15 23:08 ` pr-tracker-bot
2020-10-16 1:54 ` Linus Torvalds
2020-10-16 2:21 ` Steven Rostedt
2020-10-16 2:53 ` Masami Hiramatsu
2020-10-16 3:54 ` Steven Rostedt
2020-10-16 4:05 ` Masami Hiramatsu [this message]
2020-10-16 4:20 ` [PATCH] tracing: Remove __init from __trace_early_add_new_event() Masami Hiramatsu
2020-10-16 2:34 ` [GIT PULL] tracing: Updates for 5.10 Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016130545.caea7a3312ca2ee32990af61@kernel.org \
--to=mhiramat@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).