From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E32F6C43457 for ; Fri, 16 Oct 2020 21:32:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 809D821D40 for ; Fri, 16 Oct 2020 21:32:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602883927; bh=sONpstJsGgC+AA1Ry+CXKRFgauKStQSxfQ1R0eaWOt4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=QSZCNqFzRZ7UoIh/BOorfccAdeX4LEhPyd0xQcTROaQOqAFLK/GjGLbQAZahibWRT nVoyez9c4iwVtfA0x4oA5m83maHKjb5u7CcfnqW05Y+GToNzM04+1nNoScG1/rkwZm 04INAMxRbKAqVtX4KZLqNbqmxpqokHptm10ILsPs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2411368AbgJPVcG (ORCPT ); Fri, 16 Oct 2020 17:32:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:50638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2411354AbgJPVcF (ORCPT ); Fri, 16 Oct 2020 17:32:05 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 643E9216C4; Fri, 16 Oct 2020 21:32:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602883925; bh=sONpstJsGgC+AA1Ry+CXKRFgauKStQSxfQ1R0eaWOt4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SbPF+VDu/jBRH1m5MvpW9XhPZ4Sa4ZpSiRvUJwIZT+/uH5hm6FRU8AUj3DsSqg8Nq fVwUzH43wH/cqVEaNmVp20VhEHP+Q/hHTSjLrezRwYqsGbls5JOVhk1W1YrPkxO+gA RpR9RF4f+4rz82e5zxOhNf0iDrz76/S7H82AXP/Q= Date: Fri, 16 Oct 2020 14:32:01 -0700 From: Jakub Kicinski To: Jesse Brandeburg Cc: Ian Rogers , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , "David S. Miller" , Igor Russkikh , Mark Starovoytov , Horatiu Vultur , Antoine Tenart , "Toke =?UTF-8?B?SMO4aWxhbmQt?= =?UTF-8?B?SsO4cmdlbnNlblw=?=" , Nikolay Aleksandrov , Roopa Prabhu , Jiri Pirko , Vlad Buslov , Ido Schimmel , Alexandre Cassen , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 1/2] tools/include: Update if_link.h and netlink.h Message-ID: <20201016143201.0c12c03b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201016142348.0000452b@intel.com> References: <20201015223119.1712121-1-irogers@google.com> <20201016142348.0000452b@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Oct 2020 14:23:48 -0700 Jesse Brandeburg wrote: > > These are tested to be the latest as part of the tools/lib/bpf build. > > But you didn't mention why you're making these changes, and you're > removing a lot of comments without explaining why/where there might be > a replacement or why the comments are useless. I now see that you're > adding actual kdoc which is good, except for the part where > you don't put kdoc on all the structures. Note that he's just syncing the uAPI headers to tools/ The source of the change is here: 78a3ea555713 ("net: remove comments on struct rtnl_link_stats") 0db0c34cfbc9 ("net: tighten the definition of interface statistics")