* [PATCH] rcu-tasks: Add missing inline to show_rcu_tasks_rude_gp_kthread() dummy
@ 2020-10-16 10:31 Geert Uytterhoeven
2020-10-17 15:38 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2020-10-16 10:31 UTC (permalink / raw)
To: Paul E . McKenney, Josh Triplett, Steven Rostedt,
Mathieu Desnoyers, Lai Jiangshan, Joel Fernandes
Cc: Alexei Starovoitov, Daniel Borkmann, rcu, linux-kernel,
Geert Uytterhoeven
If CONFIG_TINY_RCU=y:
In file included from kernel/rcu/update.c:591:
kernel/rcu/tasks.h:710:13: warning: ‘show_rcu_tasks_rude_gp_kthread’ defined but not used [-Wunused-function]
static void show_rcu_tasks_rude_gp_kthread(void) {}
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fix this by marking show_rcu_tasks_rude_gp_kthread() inline.
Fixes: e21408ceec2de5be ("rcu-tasks: Add RCU tasks to rcutorture writer stall output")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Exposed by commit 1e6c62a882155772 ("bpf: Introduce sleepable BPF
programs"), which selects TASKS_TRACE_RCU.
---
kernel/rcu/tasks.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
index d5d9f2d03e8a0ac9..8c290cc45e6fc63a 100644
--- a/kernel/rcu/tasks.h
+++ b/kernel/rcu/tasks.h
@@ -707,7 +707,7 @@ static void show_rcu_tasks_rude_gp_kthread(void)
#endif /* #ifndef CONFIG_TINY_RCU */
#else /* #ifdef CONFIG_TASKS_RUDE_RCU */
-static void show_rcu_tasks_rude_gp_kthread(void) {}
+static inline void show_rcu_tasks_rude_gp_kthread(void) {}
#endif /* #else #ifdef CONFIG_TASKS_RUDE_RCU */
////////////////////////////////////////////////////////////////////////
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rcu-tasks: Add missing inline to show_rcu_tasks_rude_gp_kthread() dummy
2020-10-16 10:31 [PATCH] rcu-tasks: Add missing inline to show_rcu_tasks_rude_gp_kthread() dummy Geert Uytterhoeven
@ 2020-10-17 15:38 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2020-10-17 15:38 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Josh Triplett, Steven Rostedt, Mathieu Desnoyers, Lai Jiangshan,
Joel Fernandes, Alexei Starovoitov, Daniel Borkmann, rcu,
linux-kernel
On Fri, Oct 16, 2020 at 12:31:44PM +0200, Geert Uytterhoeven wrote:
> If CONFIG_TINY_RCU=y:
>
> In file included from kernel/rcu/update.c:591:
> kernel/rcu/tasks.h:710:13: warning: ‘show_rcu_tasks_rude_gp_kthread’ defined but not used [-Wunused-function]
> static void show_rcu_tasks_rude_gp_kthread(void) {}
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fix this by marking show_rcu_tasks_rude_gp_kthread() inline.
>
> Fixes: e21408ceec2de5be ("rcu-tasks: Add RCU tasks to rcutorture writer stall output")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Good catch, but commit 2cf0c4b5 ("rcutorture: Make grace-period kthread
report match RCU flavor being tested") beat you to it, though apparently
by accident.
Either way, thank you for your time and attention!
Thanx, Paul
> ---
> Exposed by commit 1e6c62a882155772 ("bpf: Introduce sleepable BPF
> programs"), which selects TASKS_TRACE_RCU.
> ---
> kernel/rcu/tasks.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
> index d5d9f2d03e8a0ac9..8c290cc45e6fc63a 100644
> --- a/kernel/rcu/tasks.h
> +++ b/kernel/rcu/tasks.h
> @@ -707,7 +707,7 @@ static void show_rcu_tasks_rude_gp_kthread(void)
> #endif /* #ifndef CONFIG_TINY_RCU */
>
> #else /* #ifdef CONFIG_TASKS_RUDE_RCU */
> -static void show_rcu_tasks_rude_gp_kthread(void) {}
> +static inline void show_rcu_tasks_rude_gp_kthread(void) {}
> #endif /* #else #ifdef CONFIG_TASKS_RUDE_RCU */
>
> ////////////////////////////////////////////////////////////////////////
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-17 15:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-16 10:31 [PATCH] rcu-tasks: Add missing inline to show_rcu_tasks_rude_gp_kthread() dummy Geert Uytterhoeven
2020-10-17 15:38 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).