From: Jonathan Cameron <jic23@kernel.org>
To: Vaishnav M A <vaishnav@beagleboard.org>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
alexandru.ardelean@analog.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, jkridner@beagleboard.org,
drew@beagleboard.org, robertcnelson@beagleboard.org,
rajkovic@mikroe.com
Subject: Re: [PATCH v2] iio: light: vcnl4035 add i2c_device_id
Date: Sun, 18 Oct 2020 12:36:51 +0100 [thread overview]
Message-ID: <20201018123651.635e2ec3@archlinux> (raw)
In-Reply-To: <20201018033602.GA27912@ubuntu>
On Sun, 18 Oct 2020 09:06:02 +0530
Vaishnav M A <vaishnav@beagleboard.org> wrote:
> add i2c_device_id for the vcnl4035 driver so that
> the device can be instantiated using i2c_new_client_device
> or from userspace, useful in cases where device tree based
> description is not possible now(Eg. a device on a gbphy i2c
> adapter created by greybus)
>
> Signed-off-by: Vaishnav M A <vaishnav@beagleboard.org>
Rewrite the description and this should be fine.
Thanks,
Jonathan
> ---
> v2:
> - fix commit message
> drivers/iio/light/vcnl4035.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
> index 765c44adac57..73a28e30dddc 100644
> --- a/drivers/iio/light/vcnl4035.c
> +++ b/drivers/iio/light/vcnl4035.c
> @@ -652,6 +652,12 @@ static const struct dev_pm_ops vcnl4035_pm_ops = {
> vcnl4035_runtime_resume, NULL)
> };
>
> +static const struct i2c_device_id vcnl4035_id[] = {
> + { "vcnl4035", 0},
> + { }
> +};
> +MODULE_DEVICE_TABLE(i2c, vcnl4035_id);
> +
> static const struct of_device_id vcnl4035_of_match[] = {
> { .compatible = "vishay,vcnl4035", },
> { }
> @@ -666,6 +672,7 @@ static struct i2c_driver vcnl4035_driver = {
> },
> .probe = vcnl4035_probe,
> .remove = vcnl4035_remove,
> + .id_table = vcnl4035_id,
> };
>
> module_i2c_driver(vcnl4035_driver);
next prev parent reply other threads:[~2020-10-18 11:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 3:36 [PATCH v2] iio: light: vcnl4035 add i2c_device_id Vaishnav M A
2020-10-18 11:36 ` Jonathan Cameron [this message]
2020-10-18 15:06 ` Vaishnav M A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201018123651.635e2ec3@archlinux \
--to=jic23@kernel.org \
--cc=alexandru.ardelean@analog.com \
--cc=drew@beagleboard.org \
--cc=jkridner@beagleboard.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rajkovic@mikroe.com \
--cc=robertcnelson@beagleboard.org \
--cc=vaishnav@beagleboard.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).