LKML Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] iio: adc: mediatek: fix unset field
@ 2020-10-18 17:15 Fabien Parent
  2020-10-18 18:31 ` Andy Shevchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Fabien Parent @ 2020-10-18 17:15 UTC (permalink / raw)
  To: linux-kernel, linux-mediatek, linux-arm-kernel, linux-iio,
	matthias.bgg, jic23
  Cc: chun-hung.wu, alexandru.ardelean, pmeerw, lars, Fabien Parent

dev_comp field is used in a couple of places but it is never set. This
results in kernel oops when dereferencing a NULL pointer. Set the
`dev_comp` field correctly in the probe function.

Fixes: 6d97024dce23 ("iio: adc: mediatek: mt6577-auxadc, add mt6765 support")

Signed-off-by: Fabien Parent <fparent@baylibre.com>
---

Changelog:
V2:
	* s/of_device_get_match_data/device_get_match_data
	* include mod_devicetable.h and property.h instead of of_*.h headers

 drivers/iio/adc/mt6577_auxadc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c
index ac415cb089cd..79c1dd68b909 100644
--- a/drivers/iio/adc/mt6577_auxadc.c
+++ b/drivers/iio/adc/mt6577_auxadc.c
@@ -9,9 +9,9 @@
 #include <linux/err.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
-#include <linux/of.h>
-#include <linux/of_device.h>
+#include <linux/mod_devicetable.h>
 #include <linux/platform_device.h>
+#include <linux/property.h>
 #include <linux/iopoll.h>
 #include <linux/io.h>
 #include <linux/iio/iio.h>
@@ -276,6 +276,8 @@ static int mt6577_auxadc_probe(struct platform_device *pdev)
 		goto err_disable_clk;
 	}
 
+	adc_dev->dev_comp = device_get_match_data(&pdev->dev);
+
 	mutex_init(&adc_dev->lock);
 
 	mt6577_auxadc_mod_reg(adc_dev->reg_base + MT6577_AUXADC_MISC,
-- 
2.28.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] iio: adc: mediatek: fix unset field
  2020-10-18 17:15 [PATCH v2] iio: adc: mediatek: fix unset field Fabien Parent
@ 2020-10-18 18:31 ` Andy Shevchenko
  2020-10-18 18:33   ` Andy Shevchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2020-10-18 18:31 UTC (permalink / raw)
  To: Fabien Parent
  Cc: Linux Kernel Mailing List,
	moderated list:ARM/Mediatek SoC support, linux-arm Mailing List,
	linux-iio, Matthias Brugger, Jonathan Cameron, chun-hung.wu,
	Alexandru Ardelean, Peter Meerwald, Lars-Peter Clausen

On Sun, Oct 18, 2020 at 8:16 PM Fabien Parent <fparent@baylibre.com> wrote:
>
> dev_comp field is used in a couple of places but it is never set. This
> results in kernel oops when dereferencing a NULL pointer. Set the
> `dev_comp` field correctly in the probe function.
>
> Fixes: 6d97024dce23 ("iio: adc: mediatek: mt6577-auxadc, add mt6765 support")
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>

Shouldn't be a blank line in the tag block.

I think Jonathan can fix it, but be more careful in the future.

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] iio: adc: mediatek: fix unset field
  2020-10-18 18:31 ` Andy Shevchenko
@ 2020-10-18 18:33   ` Andy Shevchenko
  2020-10-18 19:43     ` Fabien Parent
  0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2020-10-18 18:33 UTC (permalink / raw)
  To: Fabien Parent
  Cc: Linux Kernel Mailing List,
	moderated list:ARM/Mediatek SoC support, linux-arm Mailing List,
	linux-iio, Matthias Brugger, Jonathan Cameron, chun-hung.wu,
	Alexandru Ardelean, Peter Meerwald, Lars-Peter Clausen

On Sun, Oct 18, 2020 at 9:31 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Sun, Oct 18, 2020 at 8:16 PM Fabien Parent <fparent@baylibre.com> wrote:
> >
> > dev_comp field is used in a couple of places but it is never set. This
> > results in kernel oops when dereferencing a NULL pointer. Set the
> > `dev_comp` field correctly in the probe function.
> >
> > Fixes: 6d97024dce23 ("iio: adc: mediatek: mt6577-auxadc, add mt6765 support")
> >
> > Signed-off-by: Fabien Parent <fparent@baylibre.com>
>
> Shouldn't be a blank line in the tag block.
>
> I think Jonathan can fix it, but be more careful in the future.

One more serious issue, you forgot to add tags you have gotten in the
previous round.

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] iio: adc: mediatek: fix unset field
  2020-10-18 18:33   ` Andy Shevchenko
@ 2020-10-18 19:43     ` Fabien Parent
  0 siblings, 0 replies; 4+ messages in thread
From: Fabien Parent @ 2020-10-18 19:43 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Linux Kernel Mailing List,
	moderated list:ARM/Mediatek SoC support, linux-arm Mailing List,
	linux-iio, Matthias Brugger, Jonathan Cameron, chun-hung.wu,
	Alexandru Ardelean, Peter Meerwald, Lars-Peter Clausen

Hi Andy

On Sun, Oct 18, 2020 at 8:33 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Sun, Oct 18, 2020 at 9:31 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > On Sun, Oct 18, 2020 at 8:16 PM Fabien Parent <fparent@baylibre.com> wrote:
> > >
> > > dev_comp field is used in a couple of places but it is never set. This
> > > results in kernel oops when dereferencing a NULL pointer. Set the
> > > `dev_comp` field correctly in the probe function.
> > >
> > > Fixes: 6d97024dce23 ("iio: adc: mediatek: mt6577-auxadc, add mt6765 support")
> > >
> > > Signed-off-by: Fabien Parent <fparent@baylibre.com>
> >
> > Shouldn't be a blank line in the tag block.
> >
> > I think Jonathan can fix it, but be more careful in the future.
>
> One more serious issue, you forgot to add tags you have gotten in the
> previous round.

Thanks for the review. I will make it easy for the maintainer and send
right away a v3 that fixes both issues you pointed out.

> --
> With Best Regards,
> Andy Shevchenko

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-18 17:15 [PATCH v2] iio: adc: mediatek: fix unset field Fabien Parent
2020-10-18 18:31 ` Andy Shevchenko
2020-10-18 18:33   ` Andy Shevchenko
2020-10-18 19:43     ` Fabien Parent

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git