From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED9D0C433DF for ; Sun, 18 Oct 2020 19:53:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4ADE22263 for ; Sun, 18 Oct 2020 19:53:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603050820; bh=vJFXUUXbzdk6b30x0KD3inikwaRRFzDEaCtkhqDKtxk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ZJ3AikqmESE+fofQAgELu2V0sNzM995oyP6+pxEMyy2/dt52BmVx5uBOxRrbdZz0P c07+Dv0vB7IFkyb95dQq11UzhQKk46FgRciWnzJdCxdtdVG4B5BZgSAlVHwdgT9daS ynd8Ggxt+1GG8cFumperUkIQuYQeBo1SIltc4Yts= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388006AbgJRTxj (ORCPT ); Sun, 18 Oct 2020 15:53:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:60422 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728952AbgJRTUi (ORCPT ); Sun, 18 Oct 2020 15:20:38 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1389222B9; Sun, 18 Oct 2020 19:20:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603048838; bh=vJFXUUXbzdk6b30x0KD3inikwaRRFzDEaCtkhqDKtxk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aNKgF5QGh9Ccir1uZaJppTLDUm1zrlbaD1vmbvg8XSBYZTLyMfxO0CNhXko4WQOp1 gmHrc92FmsC7ryWf2mueXd1DDO7ylOyii0v8kLO3fIg0Nuvi5S4oYO4vSOo8ex1ppR h3lIvyWSJU5++VNzMbMorWe/55sSTwzfG2N6tV90= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Aditya Pakki , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 5.8 009/101] media: st-delta: Fix reference count leak in delta_run_work Date: Sun, 18 Oct 2020 15:18:54 -0400 Message-Id: <20201018192026.4053674-9-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201018192026.4053674-1-sashal@kernel.org> References: <20201018192026.4053674-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aditya Pakki [ Upstream commit 57cc666d36adc7b45e37ba4cd7bc4e44ec4c43d7 ] delta_run_work() calls delta_get_sync() that increments the reference counter. In case of failure, decrement the reference count by calling delta_put_autosuspend(). Signed-off-by: Aditya Pakki Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/sti/delta/delta-v4l2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/sti/delta/delta-v4l2.c b/drivers/media/platform/sti/delta/delta-v4l2.c index 2503224eeee51..c691b3d81549d 100644 --- a/drivers/media/platform/sti/delta/delta-v4l2.c +++ b/drivers/media/platform/sti/delta/delta-v4l2.c @@ -954,8 +954,10 @@ static void delta_run_work(struct work_struct *work) /* enable the hardware */ if (!dec->pm) { ret = delta_get_sync(ctx); - if (ret) + if (ret) { + delta_put_autosuspend(ctx); goto err; + } } /* decode this access unit */ -- 2.25.1