From: Masami Hiramatsu <mhiramat@kernel.org>
To: Tom Zanussi <zanussi@kernel.org>
Cc: rostedt@goodmis.org, axelrasmussen@google.com,
mhiramat@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] tracing: More synthetic event error fixes
Date: Mon, 19 Oct 2020 00:13:46 +0900 [thread overview]
Message-ID: <20201019001346.9d53c0c942e368ab01f667bb@kernel.org> (raw)
In-Reply-To: <cover.1602883818.git.zanussi@kernel.org>
Hi Tom,
On Fri, 16 Oct 2020 16:48:21 -0500
Tom Zanussi <zanussi@kernel.org> wrote:
> Hi,
>
> This patchset addresses the synthetic event error anomalies reported
> by Masami in the last patchset [1].
>
> It turns out that most of the problems boil down to clunky separator
> parsing; adding a couple new abilities to trace_run_command() and then
> adapting the existing users seemed to me the best way to fix these
> things, and also gets rid of some code.
Thanks for your work! But I think the interface design is a bit add-hoc.
I sent a comment mail on [1/4]. Let's discuss on the thread.
> Also, to make things easier for error display, I changed these to
> preserve the original command string and pass it through the callback
> instead of rebuilding it for error display.
trace_*probe reconstruct the input from argv, are there any reason
synthetic event can not do the same thing?
(this means the command on error message can be a bit different,
see __trace_probe_log_err() in kernel/trace/trace_probe.c)
>
> I added some new error strings and removed unused ones as well, and
> added a bunch of new test cases to the synthetic parser error test
> case.
Good.
>
> I didn't see any problems running the entire ftrace testsuite or the
> test modules that also use the things that were touched here.
Thanks,
>
> Thanks,
>
> Tom
>
> [1] https://lore.kernel.org/lkml/20201014110636.139df7be275d40a23b523b84@kernel.org/
>
> The following changes since commit 6107742d15832011cd0396d821f3225b52551f1f:
>
> tracing: support "bool" type in synthetic trace events (2020-10-15 12:01:14 -0400)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git ftrace/synth-fixes-v1
>
> Tom Zanussi (4):
> tracing: Make trace_*_run_command() more flexible
> tracing: Use new trace_run_command() options
> tracing: Update synth command errors
> selftests/ftrace: Update synthetic event syntax errors
>
> kernel/trace/trace.c | 41 ++++++++--
> kernel/trace/trace.h | 12 ++-
> kernel/trace/trace_dynevent.c | 4 +-
> kernel/trace/trace_events_synth.c | 79 ++++---------------
> kernel/trace/trace_kprobe.c | 5 +-
> kernel/trace/trace_uprobe.c | 5 +-
> .../trigger-synthetic_event_syntax_errors.tc | 17 ++--
> 7 files changed, 78 insertions(+), 85 deletions(-)
>
> --
> 2.17.1
>
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2020-10-18 15:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 21:48 [PATCH 0/4] tracing: More synthetic event error fixes Tom Zanussi
2020-10-16 21:48 ` [PATCH 1/4] tracing: Make trace_*_run_command() more flexible Tom Zanussi
2020-10-18 14:20 ` Masami Hiramatsu
2020-10-18 15:15 ` Masami Hiramatsu
2020-10-19 14:35 ` Tom Zanussi
2020-10-20 13:20 ` Masami Hiramatsu
2020-10-16 21:48 ` [PATCH 2/4] tracing: Use new trace_run_command() options Tom Zanussi
2020-10-16 21:48 ` [PATCH 3/4] tracing: Update synth command errors Tom Zanussi
2020-10-16 21:48 ` [PATCH 4/4] selftests/ftrace: Update synthetic event syntax errors Tom Zanussi
2020-10-18 15:13 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019001346.9d53c0c942e368ab01f667bb@kernel.org \
--to=mhiramat@kernel.org \
--cc=axelrasmussen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).