From: Steven Rostedt <rostedt@goodmis.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: acme@redhat.com, linux-kernel@vger.kernel.org,
linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] libtraceevent: install html files
Date: Mon, 19 Oct 2020 09:42:34 -0400 [thread overview]
Message-ID: <20201019094234.0b36bb61@gandalf.local.home> (raw)
In-Reply-To: <20201018211912.17541-1-sudipm.mukherjee@gmail.com>
On Sun, 18 Oct 2020 22:19:12 +0100
Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
> Only the man pages were installed using "make install". Add rules to
> install html files also.
>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---
> tools/lib/traceevent/Documentation/Makefile | 14 ++++++++++++--
Thanks Sudip,
Although, to apply it to the libtraceevent.git repo, I had to strip off the
"tools/lib/traceevent/" from the file paths.
-- Steve
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/tools/lib/traceevent/Documentation/Makefile b/tools/lib/traceevent/Documentation/Makefile
> index aa72ab96c3c1..dd3d62b17140 100644
> --- a/tools/lib/traceevent/Documentation/Makefile
> +++ b/tools/lib/traceevent/Documentation/Makefile
> @@ -147,7 +147,7 @@ html: $(MAN_HTML)
>
> $(MAN_HTML) $(DOC_MAN3): asciidoc.conf
>
> -install: install-man
> +install: install-man install-html
>
> check-man-tools:
> ifdef missing_tools
> @@ -161,12 +161,22 @@ do-install-man: man
>
> install-man: check-man-tools man do-install-man
>
> -uninstall: uninstall-man
> +do-install-html: html
> + $(call QUIET_INSTALL, Documentation-html) \
> + $(INSTALL) -d -m 755 $(DESTDIR)$(htmldir); \
> + $(INSTALL) -m 644 $(OUTPUT)*.html $(DESTDIR)$(htmldir);
> +
> +install-html: check-man-tools html do-install-html
> +
> +uninstall: uninstall-man uninstall-html
>
> uninstall-man:
> $(call QUIET_UNINST, Documentation-man) \
> $(Q)$(RM) $(addprefix $(DESTDIR)$(man3dir)/,$(DOC_MAN3))
>
> +uninstall-html:
> + $(call QUIET_UNINST, Documentation-html) \
> + $(Q)$(RM) $(addprefix $(DESTDIR)$(htmldir)/,$(MAN_HTML))
>
> ifdef missing_tools
> DO_INSTALL_MAN = $(warning Please install $(missing_tools) to have the man pages installed)
next prev parent reply other threads:[~2020-10-19 13:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 21:19 [PATCH] libtraceevent: install html files Sudip Mukherjee
2020-10-19 13:42 ` Steven Rostedt [this message]
2020-10-19 18:59 ` Sudip Mukherjee
2020-10-19 22:18 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019094234.0b36bb61@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).