From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA76C43457 for ; Tue, 20 Oct 2020 08:24:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFFC8222C8 for ; Tue, 20 Oct 2020 08:24:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="Z9VvQfZm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388468AbgJTIYL (ORCPT ); Tue, 20 Oct 2020 04:24:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728071AbgJTIYK (ORCPT ); Tue, 20 Oct 2020 04:24:10 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16513C061755 for ; Tue, 20 Oct 2020 01:24:09 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id e2so884696wme.1 for ; Tue, 20 Oct 2020 01:24:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=mrQqSJa8Aar4GS8/7wrxTSVqOxQkrKDNi4m7hMd2uFo=; b=Z9VvQfZmtC1Y4vzNAz3kvptekU4P/Ibhm6rYs81RSLlGOtQRbGoNhF0miHgrwdYHCI 2IunewN5tv/iZ/vuMS8V4yUUY3j7Ziz+yrTEMkuuQLiksU6evAPMUERo7dIsOOUxRMim lknGTbVq94VjGXF2b1HajbHMEz3cs7KGOT4xs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=mrQqSJa8Aar4GS8/7wrxTSVqOxQkrKDNi4m7hMd2uFo=; b=jPHNI+kemo+f4dfndHqP6bDO+L2015QdKyTocbiHK+Hmnpody4XW/56nEVbHPnqLRo n228f5wulyV37BcXxe5dL9mdkftcX8WVEUIWpdvbonA0cKZG5bmcU1IUkVZKd3EAR341 q7AoNDmdsyRtCRpFjlRe3U0uUQzc20H+sh+a4vnPosVIFTkoQJA7tm+eOw9dGOlxT0QM UiUDXwKn12n+F5y1NcwwpfGjND87z/+Hh4RrE6sZg69gtRgLN/GQ0Xp8xq/aK8mo+IO/ 3Pc+15D/J5TsJz9y/+yjUuAVLKFfc+pCaY9MaqSubq2tO7OU+q2NW2XToQENJoVFKUCD Wn6A== X-Gm-Message-State: AOAM530g7zQpWQEkYIIbqJpW9ki4XT6mV6uQBuAN6fGoSUw/dC6r5K58 X55bF3nvqqB+ufAViVgItzadtQ== X-Google-Smtp-Source: ABdhPJwtLShOv1ZYV3eB9CMVZJLNc4lIYGe5fxTpbduot0zqOSM7NvO9zRraNoE7IJWH4luZXHdLcQ== X-Received: by 2002:a1c:68d5:: with SMTP id d204mr1659695wmc.100.1603182247741; Tue, 20 Oct 2020 01:24:07 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id p67sm1561934wmp.11.2020.10.20.01.24.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2020 01:24:06 -0700 (PDT) Date: Tue, 20 Oct 2020 10:24:04 +0200 From: Daniel Vetter To: Rob Clark Cc: dri-devel@lists.freedesktop.org, Akhil P Oommen , Tanmay Shah , Bjorn Andersson , AngeloGioacchino Del Regno , Sam Ravnborg , Emil Velikov , Rob Clark , Jonathan Marek , Qinglang Miao , Roy Spliet , Wambui Karuga , linux-arm-msm@vger.kernel.org, Sharat Masetty , Kalyan Thota , Rajendra Nayak , "Gustavo A. R. Silva" , open list , tongtiangen , Thomas Zimmermann , Drew Davenport , "open list:DRM DRIVER FOR MSM ADRENO GPU" Subject: Re: [PATCH 0/3] drm/msm: kthread_worker conversion Message-ID: <20201020082404.GJ401619@phenom.ffwll.local> Mail-Followup-To: Rob Clark , dri-devel@lists.freedesktop.org, Akhil P Oommen , Tanmay Shah , Bjorn Andersson , AngeloGioacchino Del Regno , Sam Ravnborg , Emil Velikov , Rob Clark , Jonathan Marek , Qinglang Miao , Roy Spliet , Wambui Karuga , linux-arm-msm@vger.kernel.org, Sharat Masetty , Kalyan Thota , Rajendra Nayak , "Gustavo A. R. Silva" , open list , tongtiangen , Thomas Zimmermann , Drew Davenport , "open list:DRM DRIVER FOR MSM ADRENO GPU" References: <20201019211101.143327-1-robdclark@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201019211101.143327-1-robdclark@gmail.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 19, 2020 at 02:10:50PM -0700, Rob Clark wrote: > From: Rob Clark > > In particular, converting the async atomic commit (for cursor updates, > etc) to SCHED_FIFO kthread_worker helps with some cases where we > wouldn't manage to flush the updates within the 1ms-before-vblank > deadline resulting in fps drops when there is cursor movement. > > Rob Clark (3): > drm/msm/gpu: Convert retire/recover work to kthread_worker > drm/msm/kms: Update msm_kms_init/destroy > drm/msm/atomic: Convert to per-CRTC kthread_work So i915 has it's own commit worker already for $reasons, but I don't think that's a good path to go down with more drivers. And the problem seems entirely generic in nature ... -Daniel > > drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 3 +-- > drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 6 ++--- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 4 +-- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 4 +-- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 8 +++++- > drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 8 +++++- > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 11 ++++++--- > drivers/gpu/drm/msm/disp/mdp_kms.h | 9 +++++-- > drivers/gpu/drm/msm/msm_atomic.c | 25 +++++++++++++++---- > drivers/gpu/drm/msm/msm_drv.h | 3 ++- > drivers/gpu/drm/msm/msm_gpu.c | 30 +++++++++++++++-------- > drivers/gpu/drm/msm/msm_gpu.h | 13 +++++++--- > drivers/gpu/drm/msm/msm_kms.h | 23 ++++++++++++++--- > 13 files changed, 104 insertions(+), 43 deletions(-) > > -- > 2.26.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch