From: Mark Brown <broonie@kernel.org>
To: Olivier Moysan <olivier.moysan@st.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
alexandre.torgue@st.com, arnaud.patard@rtp-net.org,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-kernel@vger.kernel.org, arnaud.pouliquen@st.com
Subject: Re: [PATCH] ASoC: cs42l51: manage mclk shutdown delay
Date: Tue, 20 Oct 2020 13:19:13 +0100 [thread overview]
Message-ID: <20201020121913.GB9448@sirena.org.uk> (raw)
In-Reply-To: <20201020090457.340-1-olivier.moysan@st.com>
[-- Attachment #1: Type: text/plain, Size: 768 bytes --]
On Tue, Oct 20, 2020 at 11:04:57AM +0200, Olivier Moysan wrote:
> +static int mclk_event(struct snd_soc_dapm_widget *w,
> + struct snd_kcontrol *kcontrol, int event)
> +{
> + struct snd_soc_component *comp = snd_soc_dapm_to_component(w->dapm);
> + struct cs42l51_private *cs42l51 = snd_soc_component_get_drvdata(comp);
> +
> + if (SND_SOC_DAPM_EVENT_ON(event))
> + return clk_prepare_enable(cs42l51->mclk_handle);
> +
> + /* Delay mclk shutdown to fulfill power-down sequence requirements */
> + msleep(20);
> + clk_disable_unprepare(cs42l51->mclk_handle);
Why not use a switch statement here? The control flow is a bit odd with
what's basically an if/else done with only one branch in the if - this
isn't idiomatic for DAPM stuff apart from anything else.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-10-20 12:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 9:04 [PATCH] ASoC: cs42l51: manage mclk shutdown delay Olivier Moysan
2020-10-20 12:19 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020121913.GB9448@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.patard@rtp-net.org \
--cc=arnaud.pouliquen@st.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=olivier.moysan@st.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).