From: Bjorn Helgaas <helgaas@kernel.org>
To: trix@redhat.com
Cc: linus.walleij@linaro.org, lorenzo.pieralisi@arm.com,
robh@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci: remove unneeded break
Date: Tue, 20 Oct 2020 11:02:59 -0500 [thread overview]
Message-ID: <20201020160259.GA370179@bjorn-Precision-5520> (raw)
In-Reply-To: <20201019190249.7825-1-trix@redhat.com>
On Mon, Oct 19, 2020 at 12:02:49PM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Applied with Linus' reviewed-by to pci/misc for v5.10, thanks!
> ---
> drivers/pci/controller/pci-v3-semi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pci-v3-semi.c b/drivers/pci/controller/pci-v3-semi.c
> index 1f54334f09f7..154a5398633c 100644
> --- a/drivers/pci/controller/pci-v3-semi.c
> +++ b/drivers/pci/controller/pci-v3-semi.c
> @@ -658,7 +658,6 @@ static int v3_get_dma_range_config(struct v3_pci *v3,
> default:
> dev_err(v3->dev, "illegal dma memory chunk size\n");
> return -EINVAL;
> - break;
> }
> val |= V3_PCI_MAP_M_REG_EN | V3_PCI_MAP_M_ENABLE;
> *pci_map = val;
> --
> 2.18.1
>
prev parent reply other threads:[~2020-10-20 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 19:02 [PATCH] pci: remove unneeded break trix
2020-10-20 13:23 ` Linus Walleij
2020-10-20 16:02 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020160259.GA370179@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).