From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B71ABC561F8 for ; Wed, 21 Oct 2020 05:09:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 610CF22242 for ; Wed, 21 Oct 2020 05:09:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603256996; bh=IdutI6kcf3DrDEnl2ResNV9pkENKCDuMmln8DC3a2Sw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=F8ZFKRVZ8c3WS9iOWNIYR9noWWmdh0BvYTc8AecJccvprQ7gbqQcNPHOazSOWfND5 Onw50wbOXf4ax6LZchpSDyVrzqS8lWVFj/hnqiPk8HX8FvwGiQ1ccL8HDoix8gE7l+ Nznfb3SJ5TVBI7/FqhZJl2Cjo3y6K8oEF6TmiVqg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440366AbgJUFJz (ORCPT ); Wed, 21 Oct 2020 01:09:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:48516 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2440357AbgJUFJy (ORCPT ); Wed, 21 Oct 2020 01:09:54 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B220421D43; Wed, 21 Oct 2020 05:09:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603256994; bh=IdutI6kcf3DrDEnl2ResNV9pkENKCDuMmln8DC3a2Sw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XWR465sEBJRMEo9XWg/rzOUi4X4zoZPLCpB72Wgb6NZIdDf/f/GLaGQDOl5SdxQdE 4g7HXJODAFP3ikrO1MAL/L+vlohewsT30BschtcWrvOFyqgDG1ESuQXS7icWw/VyPs 1y3a8Wj9npcr+GtEilun5m3MKkPk4kKWtKZalYmg= Date: Wed, 21 Oct 2020 07:10:35 +0200 From: "gregkh@linuxfoundation.org" To: HyungJae Im Cc: "manivannan.sadhasivam@linaro.org" , "linux-kernel@vger.kernel.org" , "linux-input@vger.kernel.org" , "rydberg@bitmath.org" , "dmitry.torokhov@gmail.com" Subject: Re: [PATCH] FROMLIST: input: add 2 kind of switch Message-ID: <20201021051035.GA966058@kroah.com> References: <20201021031216epcms1p556d8d7d5d763ec47f67cd8cbe3972935@epcms1p5> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201021031216epcms1p556d8d7d5d763ec47f67cd8cbe3972935@epcms1p5> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 21, 2020 at 12:12:16PM +0900, HyungJae Im wrote: > >From ec9859ee01b7bc0e04255971e0fe97348847dab7 Mon Sep 17 00:00:00 2001 You sent this 3 times, why? And why is this in the body of the email, have you read the "how to send your first kernel patch" document at kernelnewbies.org? > From: "hj2.im" > Date: Tue, 20 Oct 2020 16:57:04 +0900 > Subject: [PATCH] FROMLIST: input: add 2 kind of switch What does "FROMLIST:" mean? > > We need support to various accessories on the device, > some switch does not exist in switch list. > So added switch for the following purpose. > > SW_COVER_ATTACHED is for the checking the cover > attached or not on the device. SW_EXT_PEN_ATTACHED is for the > checking the external pen attached or not on the device > > Signed-off-by: hj2.im As per the kernel documentation, you need to use your real name here, please do so. > --- > include/linux/mod_devicetable.h | 2 +- > include/uapi/linux/input-event-codes.h | 4 +++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h > index 5b08a473cdba..897f5a3e7721 100644 > --- a/include/linux/mod_devicetable.h > +++ b/include/linux/mod_devicetable.h > @@ -320,7 +320,7 @@ struct pcmcia_device_id { > #define INPUT_DEVICE_ID_LED_MAX 0x0f > #define INPUT_DEVICE_ID_SND_MAX 0x07 > #define INPUT_DEVICE_ID_FF_MAX 0x7f > -#define INPUT_DEVICE_ID_SW_MAX 0x10 > +#define INPUT_DEVICE_ID_SW_MAX 0x12 > #define INPUT_DEVICE_ID_PROP_MAX 0x1f > > #define INPUT_DEVICE_ID_MATCH_BUS 1 > diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h > index 0c2e27d28e0a..8ca2acee1f92 100644 > --- a/include/uapi/linux/input-event-codes.h > +++ b/include/uapi/linux/input-event-codes.h > @@ -889,7 +889,9 @@ > #define SW_MUTE_DEVICE 0x0e /* set = device disabled */ > #define SW_PEN_INSERTED 0x0f /* set = pen inserted */ > #define SW_MACHINE_COVER 0x10 /* set = cover closed */ > -#define SW_MAX 0x10 > +#define SW_COVER_ATTACHED 0x11 /* set = cover attached */ > +#define SW_EXT_PEN_ATTACHED 0x12 /* set = external pen attached */ Is there an in-kernel user for these values anywhere? Please submit this patch along with the users at the same time, otherwise this change makes no sense at all. thanks, greg k-h