From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ABF7C388F7 for ; Thu, 22 Oct 2020 12:34:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C641223FB for ; Thu, 22 Oct 2020 12:34:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504221AbgJVMeK (ORCPT ); Thu, 22 Oct 2020 08:34:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:60718 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438625AbgJVMeJ (ORCPT ); Thu, 22 Oct 2020 08:34:09 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C14A0AD2F; Thu, 22 Oct 2020 12:34:08 +0000 (UTC) Date: Thu, 22 Oct 2020 14:34:06 +0200 From: Oscar Salvador To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Pavel Tatashin , David Hildenbrand , Joonsoo Kim Subject: Re: [PATCH v2 3/7] mm, page_alloc: remove setup_pageset() Message-ID: <20201022123355.GA26121@linux> References: <20201008114201.18824-1-vbabka@suse.cz> <20201008114201.18824-4-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201008114201.18824-4-vbabka@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 08, 2020 at 01:41:57PM +0200, Vlastimil Babka wrote: > We initialize boot-time pagesets with setup_pageset(), which sets high and > batch values that effectively disable pcplists. > > We can remove this wrapper if we just set these values for all pagesets in > pageset_init(). Non-boot pagesets then subsequently update them to the proper > values. > > No functional change. > > Signed-off-by: Vlastimil Babka > Reviewed-by: David Hildenbrand I think I already reviewed this one, but: Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE L3