From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBC5CC4363A for ; Fri, 23 Oct 2020 16:56:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8386B241A4 for ; Fri, 23 Oct 2020 16:56:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S465256AbgJWQ4r (ORCPT ); Fri, 23 Oct 2020 12:56:47 -0400 Received: from mx2.suse.de ([195.135.220.15]:60800 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S461853AbgJWQ4q (ORCPT ); Fri, 23 Oct 2020 12:56:46 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CB4E7AC82; Fri, 23 Oct 2020 16:56:44 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 8964D1E1348; Fri, 23 Oct 2020 18:56:44 +0200 (CEST) Date: Fri, 23 Oct 2020 18:56:44 +0200 From: Jan Kara To: Tianxianting Cc: Jan Kara , "tytso@mit.edu" , "adilger.kernel@dilger.ca" , "linux-ext4@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ext4: remove the null check of bio_vec page Message-ID: <20201023165644.GG9119@quack2.suse.cz> References: <20201020082201.34257-1-tian.xianting@h3c.com> <20201021102503.GC19726@quack2.suse.cz> <113ad7d2cbfd43a9972ad37df66e5542@h3c.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <113ad7d2cbfd43a9972ad37df66e5542@h3c.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 23-10-20 16:38:16, Tianxianting wrote: > Thanks Jan > Can be the patch applied? Ted Tso is the ext4 maintainer so he should eventually pick up and apply the patch. But since there's merge window currently open, I guess he's busy shuffling patches to send to Linus. I'd expect he'll get to your patch in a week or two. Honza > > -----Original Message----- > From: Jan Kara [mailto:jack@suse.cz] > Sent: Wednesday, October 21, 2020 6:25 PM > To: tianxianting (RD) > Cc: tytso@mit.edu; adilger.kernel@dilger.ca; jack@suse.cz; linux-ext4@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] ext4: remove the null check of bio_vec page > > On Tue 20-10-20 16:22:01, Xianting Tian wrote: > > bv_page can't be NULL in a valid bio_vec, so we can remove the NULL > > check, as we did in other places when calling > > bio_for_each_segment_all() to go through all bio_vec of a bio. > > > > Signed-off-by: Xianting Tian > > Thanks for the patch. It looks good to me. You can add: > > Reviewed-by: Jan Kara > > Honza > > > --- > > fs/ext4/page-io.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c index > > defd2e10d..cb135a944 100644 > > --- a/fs/ext4/page-io.c > > +++ b/fs/ext4/page-io.c > > @@ -111,9 +111,6 @@ static void ext4_finish_bio(struct bio *bio) > > unsigned under_io = 0; > > unsigned long flags; > > > > - if (!page) > > - continue; > > - > > if (fscrypt_is_bounce_page(page)) { > > bounce_page = page; > > page = fscrypt_pagecache_page(bounce_page); > > -- > > 2.17.1 > > > -- > Jan Kara > SUSE Labs, CR -- Jan Kara SUSE Labs, CR