From: Andrea Righi <email@example.com> To: Harshad Shirwadkar <firstname.lastname@example.org> Cc: Theodore Ts'o <email@example.com>, Andreas Dilger <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org Subject: swap file broken with ext4 fast-commit Date: Sat, 24 Oct 2020 15:13:33 +0200 [thread overview] Message-ID: <20201024131333.GA32124@xps-13-7390> (raw) I'm getting the following error if I try to create and activate a swap file defined on an ext4 filesystem: [ 34.406479] swapon: file is not committed The swap file is created in the root filesystem (ext4 mounted with the following options): $ grep " / " /proc/mounts /dev/vda1 / ext4 rw,relatime 0 0 No matter how long I wait or how many times I run sync, I'm still getting the same error and the swap file is never activated. A git bisect shows that this issue has been introduced by the following commit: aa75f4d3daae ("ext4: main fast-commit commit path") Simple test case to reproduce the problem: # fallocate -l 8G /swapfile # chmod 0600 /swapfile # mkswap /swapfile # swapon /swapfile Maybe we're missing to mark the inode as clean somewhere, even if the transation is committed to the journal? Thanks, -Andrea
next reply other threads:[~2020-10-24 13:13 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-24 13:13 Andrea Righi [this message] 2020-10-24 13:38 ` Andrea Righi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201024131333.GA32124@xps-13-7390 \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: swap file broken with ext4 fast-commit' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).