LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Chen-Yu Tsai <wens@kernel.org>
To: Maxime Ripard <mripard@kernel.org>,
	Jernej Skrabec <jernej.skrabec@siol.net>
Cc: linux-sunxi@googlegroups.com, Chen-Yu Tsai <wens@csie.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 09/10] arm64: dts: allwinner: h5: libretech-all-h5-cc: Enable RGMII RX/TX delay on PHY
Date: Sun, 25 Oct 2020 00:25:14 +0800
Message-ID: <20201024162515.30032-9-wens@kernel.org> (raw)
In-Reply-To: <20201024162515.30032-1-wens@kernel.org>

From: Chen-Yu Tsai <wens@csie.org>

The Ethernet PHY on the Libre Computer ALL-H5-CC has the RX and TX
delays enabled on the PHY, using pull-ups on the RXDLY and TXDLY pins.

Fix the phy-mode description to correct reflect this so that the
implementation doesn't reconfigure the delays incorrectly. This
happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e
rx/tx delay config").

Fixes: 60d0426d7603 ("arm64: dts: allwinner: h5: Add Libre Computer ALL-H5-CC H5 board")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 arch/arm64/boot/dts/allwinner/sun50i-h5-libretech-all-h5-cc.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-libretech-all-h5-cc.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-libretech-all-h5-cc.dts
index df1b9263ad0e..6e30a564c87f 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-libretech-all-h5-cc.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-libretech-all-h5-cc.dts
@@ -36,7 +36,7 @@ &emac {
 	pinctrl-0 = <&emac_rgmii_pins>;
 	phy-supply = <&reg_gmac_3v3>;
 	phy-handle = <&ext_rgmii_phy>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	/delete-property/ allwinner,leds-active-low;
 	status = "okay";
 };
-- 
2.28.0


  parent reply index

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-24 16:25 [PATCH 01/10] Revert "arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high" Chen-Yu Tsai
2020-10-24 16:25 ` [PATCH 02/10] ARM: dts: sun6i: a31-hummingbird: Enable RGMII RX/TX delay on Ethernet PHY Chen-Yu Tsai
2020-10-24 17:51   ` [linux-sunxi] " Icenowy Zheng
2020-10-24 18:30     ` Jernej Škrabec
2020-10-24 18:39       ` Icenowy Zheng
2020-10-24 19:09         ` Clément Péron
2020-10-26  7:38         ` Ard Biesheuvel
2020-10-25  8:58   ` Jernej Škrabec
2020-10-24 16:25 ` [PATCH 03/10] ARM: dts: sun7i: cubietruck: " Chen-Yu Tsai
2020-10-24 17:04   ` [linux-sunxi] " Emilio López
2020-10-24 16:25 ` [PATCH 04/10] ARM: dts: sun7i: bananapi-m1-plus: " Chen-Yu Tsai
2020-10-25  8:51   ` Jernej Škrabec
2020-10-24 16:25 ` [PATCH 05/10] ARM: dts: sun8i: h3: orangepi-plus2e: " Chen-Yu Tsai
2020-10-25  7:53   ` Jernej Škrabec
2020-10-24 16:25 ` [PATCH 06/10] ARM: dts: sun8i: a83t: Enable both " Chen-Yu Tsai
2020-10-25  8:48   ` Jernej Škrabec
2020-10-24 16:25 ` [PATCH 07/10] ARM: dts: sun9i: " Chen-Yu Tsai
2020-10-25  8:40   ` Jernej Škrabec
2020-10-24 16:25 ` [PATCH 08/10] ARM: dts: sunxi: bananapi-m2-plus: Enable " Chen-Yu Tsai
2020-10-25  8:01   ` Jernej Škrabec
2020-10-24 16:25 ` Chen-Yu Tsai [this message]
2020-10-25  9:02   ` [PATCH 09/10] arm64: dts: allwinner: h5: libretech-all-h5-cc: Enable RGMII RX/TX delay on PHY Jernej Škrabec
2020-10-24 16:25 ` [PATCH 10/10] arm64: dts: allwinner: a64: bananapi-m64: " Chen-Yu Tsai
2020-10-24 19:58   ` [linux-sunxi] " Corentin Labbe
2020-10-25  8:34     ` Jernej Škrabec
2020-10-26 10:24   ` Maxime Ripard
2020-10-25  7:35 ` [PATCH 01/10] Revert "arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high" Jernej Škrabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201024162515.30032-9-wens@kernel.org \
    --to=wens@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@siol.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mripard@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git