From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3DA6C5517A for ; Sat, 24 Oct 2020 19:28:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 903A022276 for ; Sat, 24 Oct 2020 19:28:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603567727; bh=V5O9QNsEnPhB/nJSSUUUIHAvLcjBUCQeECX5+B4vJ7E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=jwS8SY2RnI80ZayTjkbhAlFLWkPcyYydee/zCBLNRUPgDWXFmvVMYBdXp+C+aLWf1 SsrwV8QawLAxS+nP86ihNmL+XQussWQTvUBwi8KBcga7t9AVdEmnS3Y37eZY0FVazK 6fH59khS9NnkOOFFS+46IQRRFGsz8DJTbTeihN20= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764031AbgJXT2p (ORCPT ); Sat, 24 Oct 2020 15:28:45 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:44984 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760426AbgJXT2o (ORCPT ); Sat, 24 Oct 2020 15:28:44 -0400 Received: by mail-ed1-f68.google.com with SMTP id t20so5040660edr.11; Sat, 24 Oct 2020 12:28:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e4VBZrIVbXA5K5+1xS8Vj2wOcFTF1ErdEn+41O+kAnI=; b=XDKfwaJj8eGL+G4NfUNuTTunaGyFZjcSBPAWGjLZ6gvknWYHOD+sF1/iy50gr5sJyB eDYa0RtTjGGriDtoNsy8gUh4FUj3HjOjl0xGhBk8PzgDmvMYXgOzTBGy+eeu9GyOn+KO 9URCWXEfVTHLMLYIXwjd2asS/S/HphkbeqbniPDa0LKRrIPiLYNpSV47uGB2hOOK0nkM y61hgL3Q0dEXFnwFa5fqXX5fMHw/4F4d71NYvIWerhAjVSaDErp7wfUmnoTBovBeHvrc IJrN8F9377YxGPFSSzPU5+9YyxBaeRjILVbpskKjBwI3UG2sghINeisuK6uYohn/mkAN 4uCg== X-Gm-Message-State: AOAM530j0CAdgGXEhkydHjzm+MnuV3ah201syJhyCNHJ+a+Cp5MUlE2q GRJ2QUop6hUsdHNKzpD8C14FbakRhh4= X-Google-Smtp-Source: ABdhPJyRoEAbypDQg0qtaAsbMF+T7hVlpTz9RCVWfQQu8jR7NTFcNbptSFnllzrrpdcbVbtXrbx9Sg== X-Received: by 2002:a50:9e82:: with SMTP id a2mr8219658edf.117.1603567722004; Sat, 24 Oct 2020 12:28:42 -0700 (PDT) Received: from kozik-lap ([194.230.155.174]) by smtp.googlemail.com with ESMTPSA id 22sm2746047ejw.27.2020.10.24.12.28.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Oct 2020 12:28:40 -0700 (PDT) Date: Sat, 24 Oct 2020 21:28:38 +0200 From: Krzysztof Kozlowski To: Peng Fan Cc: "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , "kernel@pengutronix.de" , dl-linux-imx , "linux-i2c@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] i2c: imx: use devm_request_threaded_irq to simplify code Message-ID: <20201024192838.GB4638@kozik-lap> References: <1603441103-17735-1-git-send-email-peng.fan@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 24, 2020 at 07:39:47AM +0000, Peng Fan wrote: > > Subject: Re: [PATCH 1/2] i2c: imx: use devm_request_threaded_irq to simplify > > code > > > > On Fri, 23 Oct 2020 at 10:27, wrote: > > > > > > From: Peng Fan > > > > > > Use devm_request_threaded_irq to simplify code > > > > > > Signed-off-by: Peng Fan > > > --- > > > drivers/i2c/busses/i2c-imx.c | 10 +++------- > > > 1 file changed, 3 insertions(+), 7 deletions(-) > > > > > > diff --git a/drivers/i2c/busses/i2c-imx.c > > > b/drivers/i2c/busses/i2c-imx.c index e6f8d6e45a15..ba9d639223ec 100644 > > > --- a/drivers/i2c/busses/i2c-imx.c > > > +++ b/drivers/i2c/busses/i2c-imx.c > > > @@ -1216,8 +1216,8 @@ static int i2c_imx_probe(struct platform_device > > *pdev) > > > goto rpm_disable; > > > > > > /* Request IRQ */ > > > - ret = request_threaded_irq(irq, i2c_imx_isr, NULL, IRQF_SHARED, > > > - pdev->name, i2c_imx); > > > + ret = devm_request_threaded_irq(&pdev->dev, irq, i2c_imx_isr, > > NULL, IRQF_SHARED, > > > + pdev->name, i2c_imx); > > > > Really? You silently revert commit e50e4f0b85be ("i2c: imx: Fix external abort > > on interrupt in exit paths"). This is not a simplification but serious change. NAK. > > At least without proper reasoning of why this is suddenly safe. > > Oh, I need look at git history before. But > Is it because i2c interrupt enabled too early? I'll try your case on i.MX8M platform. Shortly, it is because shared interrupts do not go well or at all with devm-managed interrupt handlers. Probably they could be made working with additional code, e.g. devm_free_irq() call or some additional checks in interrupt handlers. But in that case there won't be much of simplification. Best regards, Krzysztof