From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16A37C5517A for ; Mon, 26 Oct 2020 08:38:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA912223B0 for ; Mon, 26 Oct 2020 08:38:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1771873AbgJZIio (ORCPT ); Mon, 26 Oct 2020 04:38:44 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:38814 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1771843AbgJZIik (ORCPT ); Mon, 26 Oct 2020 04:38:40 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 6233E1C0B96; Mon, 26 Oct 2020 09:38:37 +0100 (CET) Date: Mon, 26 Oct 2020 09:38:37 +0100 From: Pavel Machek To: Linus Torvalds Cc: Ian Kent , Ondrej Mosnacek , Christoph Hellwig , kernel list , autofs@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , the arch/x86 maintainers , Peter Anvin Subject: Re: autofs: use __kernel_write() for the autofs pipe writing causes regression in -next was Re: 5.9.0-next-20201015: autofs oops in update-binfmts Message-ID: <20201026083836.GA24911@duo.ucw.cz> References: <20201016123530.GA30444@duo.ucw.cz> <20201017100234.GA3797@amd> <20201017194758.GA9904@duo.ucw.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FCuugMFkClbJLl1L" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --FCuugMFkClbJLl1L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat 2020-10-17 17:13:20, Linus Torvalds wrote: > On Sat, Oct 17, 2020 at 12:48 PM Pavel Machek wrote: > > > > But: you are the last one to sign it off, so I assume committed it to > > git, and you are the one to talk to about fixing it. >=20 > The thing is, the commit you point to - and the one I signed off on - is = fine. >=20 > The buggy one is in linux-next, which breaks that whole "NULL means no > position" thing. >=20 > IOW, the real bug is in commit 4d03e3cc5982 ("fs: don't allow kernel > reads and writes without iter ops"), which does that bogus >=20 > kiocb.ki_pos =3D *pos; >=20 > and no, I never signed off on that. >=20 > Get it? Stop confusing people. This bug does not exist in mainline, > and never will. Because I'm not pulling that buggy commit. And I guess that's a good thing. It is now fixed in -next, too. Sorry for the noise. Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --FCuugMFkClbJLl1L Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCX5aLDAAKCRAw5/Bqldv6 8l3iAKDA9QgXwAVJMYPECRYiZvls/4K58wCfQVKE+alumoUT3rMzunV+vN1L8Jk= =r+i9 -----END PGP SIGNATURE----- --FCuugMFkClbJLl1L--