From: Jakub Kicinski <kuba@kernel.org>
To: Yi Li <yili@winhong.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net/core/dev.c : Use skb_is_gso
Date: Mon, 26 Oct 2020 09:24:03 -0700 [thread overview]
Message-ID: <20201026092403.5e0634f3@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20201026013435.1910386-1-yili@winhong.com>
On Mon, 26 Oct 2020 09:34:35 +0800 Yi Li wrote:
> Trivial fix to use func skb_is_gso in place of
> test for skb_shinfo(skb)->gso_size.
>
> Signed-off-by: Yi Li <yili@winhong.com>
So you gave up on all the drivers now?
Please replace the word "fix" in the commit message with "refactoring",
the resulting code is identical.
The subject should be something like
net: core: Use skb_is_gso() in skb_checksum_help()
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 9499a414d67e..55f66e108059 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -3205,7 +3205,7 @@ int skb_checksum_help(struct sk_buff *skb)
> if (skb->ip_summed == CHECKSUM_COMPLETE)
> goto out_set_summed;
>
> - if (unlikely(skb_shinfo(skb)->gso_size)) {
> + if (unlikely(skb_is_gso(skb))) {
> skb_warn_bad_offload(skb);
> return -EINVAL;
> }
next prev parent reply other threads:[~2020-10-26 16:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 10:30 [PATCH] net treewide: Use skb_is_gso Yi Li
2020-10-23 20:57 ` Jakub Kicinski
2020-10-26 1:34 ` [PATCH v2] net/core/dev.c : " Yi Li
2020-10-26 16:24 ` Jakub Kicinski [this message]
2020-10-27 5:59 ` [PATCH v3] net: core: Use skb_is_gso() in skb_checksum_help() Yi Li
2020-10-28 0:37 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026092403.5e0634f3@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yili@winhong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).