From: Jan Kara <jack@suse.cz>
To: Matthew Wilcox <willy@infradead.org>
Cc: Qian Cai <cai@lca.pw>, Christoph Hellwig <hch@infradead.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
linux-mm@kvack.org
Subject: Re: kernel BUG at mm/page-writeback.c:2241 [ BUG_ON(PageWriteback(page); ]
Date: Mon, 26 Oct 2020 10:49:48 +0100 [thread overview]
Message-ID: <20201026094948.GA29758@quack2.suse.cz> (raw)
In-Reply-To: <20201022004906.GQ20115@casper.infradead.org>
On Thu 22-10-20 01:49:06, Matthew Wilcox wrote:
> On Wed, Oct 21, 2020 at 08:30:18PM -0400, Qian Cai wrote:
> > Today's linux-next starts to trigger this wondering if anyone has any clue.
>
> I've seen that occasionally too. I changed that BUG_ON to VM_BUG_ON_PAGE
> to try to get a clue about it. Good to know it's not the THP patches
> since they aren't in linux-next.
>
> I don't understand how it can happen. We have the page locked, and then we do:
>
> if (PageWriteback(page)) {
> if (wbc->sync_mode != WB_SYNC_NONE)
> wait_on_page_writeback(page);
> else
> goto continue_unlock;
> }
>
> VM_BUG_ON_PAGE(PageWriteback(page), page);
>
> Nobody should be able to put this page under writeback while we have it
> locked ... right? The page can be redirtied by the code that's supposed
> to be writing it back, but I don't see how anyone can make PageWriteback
> true while we're holding the page lock.
FWIW here's very similar report for ext4 [1] and I strongly suspect this
started happening after Linus' rewrite of the page bit waiting logic. Linus
thinks it's preexisting bug which just got exposed by his changes (which is
possible). I've been searching a culprit for some time but so far I failed.
It's good to know it isn't ext4 specific so we should be searching in the
generic code ;). So far I was concentrating more on ext4 bits...
Honza
[1] https://lore.kernel.org/lkml/000000000000d3a33205add2f7b2@google.com/
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2020-10-26 9:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 0:30 kernel BUG at mm/page-writeback.c:2241 [ BUG_ON(PageWriteback(page); ] Qian Cai
2020-10-22 0:49 ` Matthew Wilcox
2020-10-22 13:23 ` William Kucharski
2020-10-22 16:46 ` Matthew Wilcox
2020-10-22 15:35 ` Qian Cai
2020-10-22 17:12 ` Matthew Wilcox
2020-10-30 12:08 ` Qian Cai
2020-10-26 9:49 ` Jan Kara [this message]
2020-10-26 13:13 ` Matthew Wilcox
2020-10-26 13:55 ` Jens Axboe
2020-10-26 14:26 ` Qian Cai
2020-11-04 15:16 ` Jan Kara
2020-11-04 15:40 ` Qian Cai
2020-10-26 14:51 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026094948.GA29758@quack2.suse.cz \
--to=jack@suse.cz \
--cc=axboe@kernel.dk \
--cc=cai@lca.pw \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).