From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8118C4363A for ; Mon, 26 Oct 2020 14:19:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7AC4C21655 for ; Mon, 26 Oct 2020 14:19:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="ZxnMHYSF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1781168AbgJZOT2 (ORCPT ); Mon, 26 Oct 2020 10:19:28 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:36364 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1780405AbgJZOS4 (ORCPT ); Mon, 26 Oct 2020 10:18:56 -0400 Received: by mail-wm1-f68.google.com with SMTP id e2so12672960wme.1 for ; Mon, 26 Oct 2020 07:18:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lQQN2ZXT/G4B3VsGNJyIkmXWhvmT1sWJqpvE2SPt6Is=; b=ZxnMHYSFOUulXDxL+4xjW3ZbztSXxsofF2iOprGDW7au+9/inxzprjpawGC8XE5PDp hL0LG/mBPxWfBER19aTZEmmOKKjE/5tAnzRdPbffZF8IR5pmnhLpifusoSDz0dFYPSKg ysXESusFqBEruE/EOvEPPKCMNdG8HnHRt4gR4EfE1LX6Ej8PRy8eMuKL0mzbCUlR3xMR iofrd6NHXXQcaEn85CFUYR0sNsR99BVyVKFsQa41iiEYrREjtoqV+Z0QNbTeNiZUjKJ3 vwYJKRDCw+IyM8LKQ2eMoPBUlXnqPJ7Kixg7NcWxyQcLfKavbmKydOUBIhIIYOUyk05g UZdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lQQN2ZXT/G4B3VsGNJyIkmXWhvmT1sWJqpvE2SPt6Is=; b=L/FO0+t36vtzabKn7avSVCFZwL//sUDVQNNkFHyHiniYijyZdFAOkUspIQ/3EH3RMY k/JRlvO4pp5Yi3jHrPo5UVNdV00JFLf9dnQWmVBPvMA4XWafNvAW3pldudeVKkrYYkN2 iAEej+W3oHfaCS9ycXEWclayjDKI50eMgG0FGymC242AD27lBAkxeiisU4ZCEfwOzIKd DWS5z8vQ5si/LgR09ng4DDkGy7LNIdVu1G6SlZvaWqErAu61HMRZkz3YL6Zq9F6N9XWD JTZrU+9GIvb/r9ZUZR4/4QvE8I0Y/qet/yEei7Ig4/AVS40epd0xi56ffT1tz7bbgVb2 gMvw== X-Gm-Message-State: AOAM5309MgeROfNnvGGfhMVJj2qVUHt2RQ5qxjP6AzoEAWioGLAxvAcn jpM6KX2Wyac+d0TewIpBM5YTsw== X-Google-Smtp-Source: ABdhPJw3ILVPqzXaP0J4qthEjWOqza5rXxTayT7WtRhNfox/0YLIDsOSTBnt3lwxo2tpWHWEz1QIuA== X-Received: by 2002:a1c:99d3:: with SMTP id b202mr11193600wme.0.1603721932973; Mon, 26 Oct 2020 07:18:52 -0700 (PDT) Received: from localhost.localdomain (lfbn-nic-1-190-206.w2-15.abo.wanadoo.fr. [2.15.39.206]) by smtp.gmail.com with ESMTPSA id e15sm21920841wro.13.2020.10.26.07.18.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 07:18:52 -0700 (PDT) From: Bartosz Golaszewski To: Sudip Mukherjee , Linus Walleij Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 3/7] gpio: exar: switch to a simpler IDA interface Date: Mon, 26 Oct 2020 15:18:35 +0100 Message-Id: <20201026141839.28536-4-brgl@bgdev.pl> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201026141839.28536-1-brgl@bgdev.pl> References: <20201026141839.28536-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bartosz Golaszewski We don't need to specify any ranges when allocating IDs so we can switch to ida_alloc() and ida_free() instead of the ida_simple_ counterparts. ida_simple_get(ida, 0, 0, gfp) is equivalent to ida_alloc_range(ida, 0, UINT_MAX, gfp) which is equivalent to ida_alloc(ida, gfp). Note: IDR will never actually allocate an ID larger than INT_MAX. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-exar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-exar.c b/drivers/gpio/gpio-exar.c index 1941ae533418..752e8437ff80 100644 --- a/drivers/gpio/gpio-exar.c +++ b/drivers/gpio/gpio-exar.c @@ -149,7 +149,7 @@ static int gpio_exar_probe(struct platform_device *pdev) mutex_init(&exar_gpio->lock); - index = ida_simple_get(&ida_index, 0, 0, GFP_KERNEL); + index = ida_alloc(&ida_index, GFP_KERNEL); if (index < 0) { ret = index; goto err_mutex_destroy; @@ -179,7 +179,7 @@ static int gpio_exar_probe(struct platform_device *pdev) return 0; err_destroy: - ida_simple_remove(&ida_index, index); + ida_free(&ida_index, index); err_mutex_destroy: mutex_destroy(&exar_gpio->lock); return ret; @@ -189,7 +189,7 @@ static int gpio_exar_remove(struct platform_device *pdev) { struct exar_gpio_chip *exar_gpio = platform_get_drvdata(pdev); - ida_simple_remove(&ida_index, exar_gpio->index); + ida_free(&ida_index, exar_gpio->index); mutex_destroy(&exar_gpio->lock); return 0; -- 2.29.1