From: Rob Herring <robh@kernel.org>
To: Jerome Pouiller <Jerome.Pouiller@silabs.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Kalle Valo" <kvalo@codeaurora.org>,
"David S . Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org, linux-mmc@vger.kernel.org,
"Pali Rohár" <pali@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>
Subject: Re: [PATCH v2 02/24] dt-bindings: introduce silabs,wfx.yaml
Date: Mon, 26 Oct 2020 09:30:24 -0500 [thread overview]
Message-ID: <20201026143024.GA95610@bogus> (raw)
In-Reply-To: <20201020125817.1632995-3-Jerome.Pouiller@silabs.com>
On Tue, Oct 20, 2020 at 02:57:55PM +0200, Jerome Pouiller wrote:
> From: Jérôme Pouiller <jerome.pouiller@silabs.com>
>
> Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
> ---
> .../bindings/net/wireless/silabs,wfx.yaml | 133 ++++++++++++++++++
> 1 file changed, 133 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/wireless/silabs,wfx.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/silabs,wfx.yaml b/Documentation/devicetree/bindings/net/wireless/silabs,wfx.yaml
> new file mode 100644
> index 000000000000..2605e9fed185
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/wireless/silabs,wfx.yaml
> @@ -0,0 +1,133 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (c) 2020, Silicon Laboratories, Inc.
> +%YAML 1.2
> +---
> +
> +$id: http://devicetree.org/schemas/net/wireless/silabs,wfx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Silicon Labs WFxxx devicetree bindings
> +
> +maintainers:
> + - Jérôme Pouiller <jerome.pouiller@silabs.com>
> +
> +description: >
> + Support for the Wifi chip WFxxx from Silicon Labs. Currently, the only device
> + from the WFxxx series is the WF200 described here:
> + https://www.silabs.com/documents/public/data-sheets/wf200-datasheet.pdf
> +
> + The WF200 can be connected via SPI or via SDIO.
> +
> + For SDIO:
> +
> + Declaring the WFxxx chip in device tree is mandatory (usually, the VID/PID is
> + sufficient for the SDIO devices).
> +
> + It is recommended to declare a mmc-pwrseq on SDIO host above WFx. Without
> + it, you may encounter issues during reboot. The mmc-pwrseq should be
> + compatible with mmc-pwrseq-simple. Please consult
> + Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.txt for more
> + information.
> +
> + For SPI:
> +
> + In add of the properties below, please consult
> + Documentation/devicetree/bindings/spi/spi-controller.yaml for optional SPI
> + related properties.
> +
> +properties:
> + compatible:
> + const: silabs,wf200
> +
> + reg:
> + description:
> + When used on SDIO bus, <reg> must be set to 1. When used on SPI bus, it is
> + the chip select address of the device as defined in the SPI devices
> + bindings.
> + maxItems: 1
> +
> + spi-max-frequency: true
> +
> + interrupts:
> + description: The interrupt line. Triggers IRQ_TYPE_LEVEL_HIGH and
> + IRQ_TYPE_EDGE_RISING are both supported by the chip and the driver. When
> + SPI is used, this property is required. When SDIO is used, the "in-band"
> + interrupt provided by the SDIO bus is used unless an interrupt is defined
> + in the Device Tree.
> + maxItems: 1
> +
> + reset-gpios:
> + description: (SPI only) Phandle of gpio that will be used to reset chip
> + during probe. Without this property, you may encounter issues with warm
> + boot. (For legacy purpose, the gpio in inverted when compatible ==
> + "silabs,wfx-spi")
> +
> + For SDIO, the reset gpio should declared using a mmc-pwrseq.
> + maxItems: 1
> +
> + wakeup-gpios:
> + description: Phandle of gpio that will be used to wake-up chip. Without this
> + property, driver will disable most of power saving features.
> + maxItems: 1
> +
> + config-file:
If this is antenna data/config, then make the property name more
specific. And it needs a vendor prefix as it is vendor specific.
> + description: Use an alternative file as PDS. Default is `wf200.pds`.
> +
> + local-mac-address:
> + $ref: /net/ethernet-controller.yaml#/properties/local-mac-address
> +
> + mac-address:
> + $ref: /net/ethernet-controller.yaml#/properties/mac-address
I'd rather see these properties refactored out to their own file. We
should probably have a wifi-controller.yaml that has these as well as
enforcing the node name 'wifi'.
> +
> +additionalProperties: true
What properties? This shouldn't be true. If you need spi-cpol or
spi-cpha, then you should list those. Really, if the SPI mode of the
device is fixed, then you should never use those.
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + spi0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + wfx@0 {
> + compatible = "silabs,wf200";
> + pinctrl-names = "default";
> + pinctrl-0 = <&wfx_irq &wfx_gpios>;
> + reg = <0>;
> + interrupts-extended = <&gpio 16 IRQ_TYPE_EDGE_RISING>;
> + wakeup-gpios = <&gpio 12 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
> + spi-max-frequency = <42000000>;
> + };
> + };
> +
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + wfx_pwrseq: wfx_pwrseq {
> + compatible = "mmc-pwrseq-simple";
> + pinctrl-names = "default";
> + pinctrl-0 = <&wfx_reset>;
> + reset-gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
> + };
> +
> + mmc0 {
> + mmc-pwrseq = <&wfx_pwrseq>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + mmc@1 {
wifi@1
> + compatible = "silabs,wf200";
> + pinctrl-names = "default";
> + pinctrl-0 = <&wfx_wakeup>;
> + reg = <1>;
> + wakeup-gpios = <&gpio 12 GPIO_ACTIVE_HIGH>;
> + };
> + };
> +...
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-10-26 14:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 12:57 [PATCH v2 00/24] wfx: get out from the staging area Jerome Pouiller
2020-10-20 12:57 ` [PATCH v2 01/24] mmc: sdio: add SDIO IDs for Silabs WF200 chip Jerome Pouiller
2020-10-20 15:07 ` Ulf Hansson
2020-10-21 22:30 ` Pali Rohár
2020-10-20 12:57 ` [PATCH v2 02/24] dt-bindings: introduce silabs,wfx.yaml Jerome Pouiller
2020-10-26 14:30 ` Rob Herring [this message]
2020-10-20 12:57 ` [PATCH v2 03/24] wfx: add Makefile/Kconfig Jerome Pouiller
2020-10-20 12:57 ` [PATCH v2 04/24] wfx: add wfx.h Jerome Pouiller
2020-10-20 12:57 ` [PATCH v2 05/24] wfx: add main.c/main.h Jerome Pouiller
2020-10-20 12:57 ` [PATCH v2 06/24] wfx: add bus.h Jerome Pouiller
2020-10-20 12:58 ` [PATCH v2 07/24] wfx: add bus_spi.c Jerome Pouiller
2020-10-20 12:58 ` [PATCH v2 08/24] wfx: add bus_sdio.c Jerome Pouiller
2020-10-20 12:58 ` [PATCH v2 09/24] wfx: add hwio.c/hwio.h Jerome Pouiller
2020-10-20 12:58 ` [PATCH v2 10/24] wfx: add fwio.c/fwio.h Jerome Pouiller
2020-10-20 12:58 ` [PATCH v2 11/24] wfx: add bh.c/bh.h Jerome Pouiller
2020-10-20 12:58 ` [PATCH v2 12/24] wfx: add hif_api_*.h Jerome Pouiller
2020-10-20 12:58 ` [PATCH v2 13/24] wfx: add hif_tx*.c/hif_tx*.h Jerome Pouiller
2020-10-20 12:58 ` [PATCH v2 14/24] wfx: add key.c/key.h Jerome Pouiller
2020-10-20 12:58 ` [PATCH v2 15/24] wfx: add hif_rx.c/hif_rx.h Jerome Pouiller
2020-10-20 12:58 ` [PATCH v2 16/24] wfx: add data_rx.c/data_rx.h Jerome Pouiller
2020-10-20 12:58 ` [PATCH v2 17/24] wfx: add queue.c/queue.h Jerome Pouiller
2020-10-20 12:58 ` [PATCH v2 18/24] wfx: add data_tx.c/data_tx.h Jerome Pouiller
2020-10-20 12:58 ` [PATCH v2 19/24] wfx: add sta.c/sta.h Jerome Pouiller
2020-10-20 12:58 ` [PATCH v2 20/24] wfx: add scan.c/scan.h Jerome Pouiller
2020-10-20 12:58 ` [PATCH v2 21/24] wfx: add debug.c/debug.h Jerome Pouiller
2020-10-20 12:58 ` [PATCH v2 22/24] wfx: add traces.h Jerome Pouiller
2020-10-20 12:58 ` [PATCH v2 23/24] wfx: remove from the staging area Jerome Pouiller
2020-10-20 12:58 ` [PATCH v2 24/24] wfx: get out " Jerome Pouiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026143024.GA95610@bogus \
--to=robh@kernel.org \
--cc=Jerome.Pouiller@silabs.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pali@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).