From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2114DC2D0A3 for ; Mon, 26 Oct 2020 17:24:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0BFA21D7B for ; Mon, 26 Oct 2020 17:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603733078; bh=r/Go5g+ydHtLSDBV/2d++cEZQyCVyOlKmRWTE3d43fs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=FpD5VzIrgduLKpTdgvLlEDHwFuqDdCFITvFAURyrHN6MDu3P9m3mSsLcuTHBv8dh0 3JlrbtQc05OkK2gR/j1iZYSMX1iyDbXq94DWA6iJfEQ0075a0FnlxPC9SLYIaAIj0/ Qwq5hu6vb+mAw3xHZiLcrWXMUNjtXWuMvhcpPsHk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1787657AbgJZRYh (ORCPT ); Mon, 26 Oct 2020 13:24:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:34000 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392010AbgJZRYh (ORCPT ); Mon, 26 Oct 2020 13:24:37 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1E99421D7B; Mon, 26 Oct 2020 17:24:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603733076; bh=r/Go5g+ydHtLSDBV/2d++cEZQyCVyOlKmRWTE3d43fs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zwf/0tJl1quToYepFt/MPzsgGsdO5FaYPLfzE+8gEOZfjiUfR9dZzBgh9BURNBWpu Slw6cxiIesxUFz9QC4IegdrLQMV4MVMAxR1d0vymwb2GBBvhcNjXZjcvQGekX/IXNK ySzjSlRToGvxUmo97SbK+l9nPBlHKhN7UN/Ac2hc= Date: Mon, 26 Oct 2020 17:24:31 +0000 From: Mark Brown To: Fabien Parent Cc: "moderated list:ARM/Mediatek SoC support" , Linux ARM , DTML , linux-kernel , Matthias Brugger , Rob Herring , lgirdwood@gmail.com, Rob Herring Subject: Re: [PATCH v5 1/2] dt-bindings: regulator: add support for MT6392 Message-ID: <20201026172431.GI7402@sirena.org.uk> References: <20201024200304.1427864-1-fparent@baylibre.com> <20201026121316.GB7402@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JIpyCmsTxyPLrmrM" Content-Disposition: inline In-Reply-To: X-Cookie: Safety Third. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --JIpyCmsTxyPLrmrM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 26, 2020 at 06:18:35PM +0100, Fabien Parent wrote: > On Mon, Oct 26, 2020 at 1:13 PM Mark Brown wrote: > > On Sat, Oct 24, 2020 at 10:03:03PM +0200, Fabien Parent wrote: > > > +Required properties: > > > +- compatible: "mediatek,mt6392-regulator" > > This is no longer used by the driver, should be unneeded and therefore > > should be removed. > It is not used by the driver but it will be used by the MFD driver [0] > like this: > static const struct mfd_cell mt6392_devs[] = { > { > [snip] > }, { > [snip] > }, { > .name = "mt6392-regulator", > .of_compatible = "mediatek,mt6392-regulator" This is still unneeded, it's just a reflection of Linux implementation details and should be removed. The MFD can just register the child without supplying a compatible and things will continue to work just as well. --JIpyCmsTxyPLrmrM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl+XBk4ACgkQJNaLcl1U h9Dn3Af/Va1AtyHzsa7Z0W0FedjMRq9j7LCJX+Kg8oMfDfIwuzNAYDW21SnhicJR JkaVl7kRqXWcx4LtXAIQp2hpiNBLr2SmVhvUxnHmsVqk/THfKWUXRAGMEfAIyl6x tkwzYaqeYSPGV8kYpy9oNnA3R27BhsqReot+ImqdmTIcDvUAIkPSsTEl/W6Ixr91 M4LG0s8lzMiTN69LPhKokDUI5fKiulX+/WdXwRuuKBS7augVcN5YJJI0bdAOlelL twQ4mb7hkrCLwg/ag2cZZagfuvPTGqol8WTuBs+6NmKkvzwBvrCiH97eu3bwO4i7 DawzoJr9YUM7MMdssy04Ui9GaICqgg== =BCjn -----END PGP SIGNATURE----- --JIpyCmsTxyPLrmrM--