From: Guenter Roeck <linux@roeck-us.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Joe Perches <joe@perches.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")
Date: Mon, 26 Oct 2020 14:27:37 -0700 [thread overview]
Message-ID: <20201026212737.GA113829@roeck-us.net> (raw)
In-Reply-To: <CAHk-=whjhHuwANGerJLJyn7jXCfMQMiaBAW+o2r_T+n=Ki+New@mail.gmail.com>
On Mon, Oct 26, 2020 at 01:33:48PM -0700, Linus Torvalds wrote:
> On Mon, Oct 26, 2020 at 12:41 PM Guenter Roeck <linux@roeck-us.net> wrote:
> >
> > make ARCH=um SUBARCH=x86_64 defconfig:
> >
> > Building um:defconfig ... failed
> > --------------
> > Error log:
> > arch/um/kernel/skas/clone.c:24:16: error: expected declaration specifiers or '...' before string constant
> > arch/x86/um/stub_segv.c:11:16: error: expected declaration specifiers or '...' before string constant
>
> Weird. Is __section() not defined somehow for those files?
>
> It does look like they have very minimal headers, so undoing that
> patch just for those two files is likely the right thing to do.
>
> > As with s390, reverting this patch fixes the problem.
>
> s390 should be fixed already.
>
> Is the attached minimal patch sufficient for um to get back to working
> order, or is there something else hiding there too?
>
That works for me.
Tested-by: Guenter Roeck <linux@roeck-us.net>
Thanks,
Guenter
prev parent reply other threads:[~2020-10-26 21:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 2:36 [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo") Joe Perches
2020-10-22 20:42 ` Nick Desaulniers
2020-10-22 20:45 ` Joe Perches
2020-10-23 6:08 ` Miguel Ojeda
2020-10-23 8:03 ` Joe Perches
2020-10-23 20:03 ` Miguel Ojeda
2020-10-26 19:36 ` Guenter Roeck
2020-10-26 19:44 ` Nathan Chancellor
2020-10-26 19:41 ` Guenter Roeck
2020-10-26 20:33 ` Linus Torvalds
2020-10-26 21:27 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026212737.GA113829@roeck-us.net \
--to=linux@roeck-us.net \
--cc=clang-built-linux@googlegroups.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ndesaulniers@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).