From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C003C55179 for ; Tue, 27 Oct 2020 07:25:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE9A12224E for ; Tue, 27 Oct 2020 07:25:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QrX7cXKr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2507600AbgJ0HZI (ORCPT ); Tue, 27 Oct 2020 03:25:08 -0400 Received: from mail-yb1-f201.google.com ([209.85.219.201]:37085 "EHLO mail-yb1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2507590AbgJ0HZH (ORCPT ); Tue, 27 Oct 2020 03:25:07 -0400 Received: by mail-yb1-f201.google.com with SMTP id h6so487080ybk.4 for ; Tue, 27 Oct 2020 00:25:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=6rOIjCU41RmBcOLQKBev/ecK/YxKmDMIy5ABsxdSYCE=; b=QrX7cXKrWwhToRwCILi0aJLfIUraRa7nc85z1nt+jfZWEBJ05TVAqrwtwoFfuEbTzJ dHEJIAmqmW0vI1ezGGRXxmwgUTJSvxLj3EG7JgaCHzu3ryA/vG60/geB33kNOakoipyL FcrN9CPKwRJzXRCM2O/rIUaF0kX4viQCXDhCQ5ZhPo4CSuDvjMZ1hkR6c9eGhCO48VO6 43qaZAn0QnNGDCBBzDl3jlGZ3C8q44/yripuJIqcXI2/2Ezy6qvG1gJEoYNqpbtwICLa wFWZNt9Xe7w5p1CuCEYX3MOfE9FAWII7fhepQTeDIYTiv5ja6Z86obJJxCZZZcf+kVGB dvGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=6rOIjCU41RmBcOLQKBev/ecK/YxKmDMIy5ABsxdSYCE=; b=GJXiB38HEck5qqwRjqX/J3xtWNhMhb98460lLS1jOnApXrk5TmuElBZQJ6DgEw36Zi uPQGhZ5FX01PjkGw0hsjeuZHnlAh2iui56nVgj6D07Dcx0olMIrbkQUIqxxIRibZ9lZY efm6Q1yW0egCaYmRB7rDyRn82U05Llq//nX2kIYwQ20+UgSceGSdJClmLFBeVxr/T5It LvOsl4iO/Fez4QNza+YmULoOjsXp1lWqlnNqqCLMYaulDGcPxL18rlF5Ti8B+WYRzTuc LiwlnevCspNLKXZjiwu8D1D6sFpEr0tdMxFS3EuIljEwPFcwQiWbpGBsGdugoFHtMZwu FbVQ== X-Gm-Message-State: AOAM5317Cx4sXm+cwsTM5kl/zjkOOgf3beoprXBGDEVMpXG74CfMT9zs 3UR7sLCqHazXg6HhaxWDmWaTcKoqJ3eaNrg6yAbMaflHY/tEn3xvBG6Dk9RFZjaKSMaLtA3W/mx +tDgGZOi4U8703MMiFWFcvKKI1Akgyvt9TZY+oFrRxhPN/6aICjiOKcJzZtk0CWc6C+QOxeWWNl 62Jbwr X-Google-Smtp-Source: ABdhPJxGQbOMLGXGj3UgCL6+1wWQWGlw+40OKZUZ688ahZtZZ3L7CpQeNb49i6nF0XZafiTvD/wCOxoPjxL/x+9A Sender: "victording via sendgmr" X-Received: from victording.syd.corp.google.com ([2401:fa00:9:14:f693:9fff:fef4:fa73]) (user=victording job=sendgmr) by 2002:a25:bd0c:: with SMTP id f12mr1215275ybk.3.1603783504108; Tue, 27 Oct 2020 00:25:04 -0700 (PDT) Date: Tue, 27 Oct 2020 07:23:56 +0000 In-Reply-To: <20201027072358.13725-1-victording@google.com> Message-Id: <20201027072358.13725-4-victording@google.com> Mime-Version: 1.0 References: <20201027072358.13725-1-victording@google.com> X-Mailer: git-send-email 2.29.0.rc2.309.g374f81d7ae-goog Subject: [PATCH v3 3/4] powercap: Add AMD Fam17h RAPL support From: Victor Ding To: linux-kernel@vger.kernel.org Cc: Daniel Lezcano , Kim Phillips , Zhang Rui , linux-pm@vger.kernel.org, Victor Ding , Borislav Petkov , "H. Peter Anvin" , Ingo Molnar , Joerg Roedel , Kan Liang , Pawan Gupta , "Peter Zijlstra (Intel)" , "Rafael J. Wysocki" , Sean Christopherson , Srinivas Pandruvada , Thomas Gleixner , Tony Luck , Vineela Tummalapalli , x86@kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch enables AMD Fam17h RAPL support for the power capping framework. The support is as per AMD Fam17h Model31h (Zen2) and model 00-ffh (Zen1) PPR. Tested by comparing the results of following two sysfs entries and the values directly read from corresponding MSRs via /dev/cpu/[x]/msr: /sys/class/powercap/intel-rapl/intel-rapl:0/energy_uj /sys/class/powercap/intel-rapl/intel-rapl:0/intel-rapl:0:0/energy_uj Signed-off-by: Victor Ding Acked-by: Kim Phillips --- Changes in v3: By Victor Ding - Rebased to the latest code. - Created a new rapl_defaults for AMD CPUs. - Removed redundant setting to zeros. - Stopped using the fake power limit domain 1. Changes in v2: By Kim Phillips : - Added Kim's Acked-by. - Added Daniel Lezcano to Cc. - (No code change). arch/x86/include/asm/msr-index.h | 1 + drivers/powercap/intel_rapl_common.c | 6 ++++++ drivers/powercap/intel_rapl_msr.c | 20 +++++++++++++++++++- 3 files changed, 26 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h index 21917e134ad4..c36a083c8ec0 100644 --- a/arch/x86/include/asm/msr-index.h +++ b/arch/x86/include/asm/msr-index.h @@ -327,6 +327,7 @@ #define MSR_PP1_POLICY 0x00000642 #define MSR_AMD_RAPL_POWER_UNIT 0xc0010299 +#define MSR_AMD_CORE_ENERGY_STATUS 0xc001029a #define MSR_AMD_PKG_ENERGY_STATUS 0xc001029b /* Config TDP MSRs */ diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_rapl_common.c index 0b2830efc574..bedd780bed12 100644 --- a/drivers/powercap/intel_rapl_common.c +++ b/drivers/powercap/intel_rapl_common.c @@ -1011,6 +1011,10 @@ static const struct rapl_defaults rapl_defaults_cht = { .compute_time_window = rapl_compute_time_window_atom, }; +static const struct rapl_defaults rapl_defaults_amd = { + .check_unit = rapl_check_unit_core, +}; + static const struct x86_cpu_id rapl_ids[] __initconst = { X86_MATCH_INTEL_FAM6_MODEL(SANDYBRIDGE, &rapl_defaults_core), X86_MATCH_INTEL_FAM6_MODEL(SANDYBRIDGE_X, &rapl_defaults_core), @@ -1061,6 +1065,8 @@ static const struct x86_cpu_id rapl_ids[] __initconst = { X86_MATCH_INTEL_FAM6_MODEL(XEON_PHI_KNL, &rapl_defaults_hsw_server), X86_MATCH_INTEL_FAM6_MODEL(XEON_PHI_KNM, &rapl_defaults_hsw_server), + + X86_MATCH_VENDOR_FAM(AMD, 0x17, &rapl_defaults_amd), {} }; MODULE_DEVICE_TABLE(x86cpu, rapl_ids); diff --git a/drivers/powercap/intel_rapl_msr.c b/drivers/powercap/intel_rapl_msr.c index a819b3b89b2f..78213d4b5b16 100644 --- a/drivers/powercap/intel_rapl_msr.c +++ b/drivers/powercap/intel_rapl_msr.c @@ -49,6 +49,14 @@ static struct rapl_if_priv rapl_msr_priv_intel = { .limits[RAPL_DOMAIN_PLATFORM] = 2, }; +static struct rapl_if_priv rapl_msr_priv_amd = { + .reg_unit = MSR_AMD_RAPL_POWER_UNIT, + .regs[RAPL_DOMAIN_PACKAGE] = { + 0, MSR_AMD_PKG_ENERGY_STATUS, 0, 0, 0 }, + .regs[RAPL_DOMAIN_PP0] = { + 0, MSR_AMD_CORE_ENERGY_STATUS, 0, 0, 0 }, +}; + /* Handles CPU hotplug on multi-socket systems. * If a CPU goes online as the first CPU of the physical package * we add the RAPL package to the system. Similarly, when the last @@ -138,7 +146,17 @@ static int rapl_msr_probe(struct platform_device *pdev) const struct x86_cpu_id *id = x86_match_cpu(pl4_support_ids); int ret; - rapl_msr_priv = &rapl_msr_priv_intel; + switch (boot_cpu_data.x86_vendor) { + case X86_VENDOR_INTEL: + rapl_msr_priv = &rapl_msr_priv_intel; + break; + case X86_VENDOR_AMD: + rapl_msr_priv = &rapl_msr_priv_amd; + break; + default: + pr_err("intel-rapl does not support CPU vendor %d\n", boot_cpu_data.x86_vendor); + return -ENODEV; + } rapl_msr_priv->read_raw = rapl_msr_read_raw; rapl_msr_priv->write_raw = rapl_msr_write_raw; -- 2.29.0.rc2.309.g374f81d7ae-goog