From: Daniel Vetter <daniel@ffwll.ch>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Patrik Jakobsson" <patrik.r.jakobsson@gmail.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Stefan Christ" <contact@stefanchrist.eu>,
"Arnd Bergmann" <arnd@arndb.de>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Emil Velikov" <emil.velikov@collabora.com>,
"Pankaj Bharadiya" <pankaj.laxminarayan.bharadiya@intel.com>,
"Rikard Falkeborn" <rikard.falkeborn@gmail.com>,
"Paul Kocialkowski" <paul.kocialkowski@bootlin.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] drm/gma500: avoid Woverride-init warning
Date: Tue, 27 Oct 2020 10:33:50 +0100 [thread overview]
Message-ID: <20201027093350.GI401619@phenom.ffwll.local> (raw)
In-Reply-To: <20201026194110.3817470-4-arnd@kernel.org>
On Mon, Oct 26, 2020 at 08:41:04PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> gcc -Wextra notices that one of the fields in psbfb_roll_ops has two
> initializers:
>
> drivers/gpu/drm/gma500/framebuffer.c:185:20: warning: initialized field overwritten [-Woverride-init]
>
> Open-code this instead, leaving out the extraneous initializers for
> .fb_pan_display.
>
> Fixes: 3da6c2f3b730 ("drm/gma500: use DRM_FB_HELPER_DEFAULT_OPS for fb_ops")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Scrollback is dead, so I'm not sure it's even worth to keep all this. I'd
just garbage-collect this, maybe als the entire accelerator code and just
leave psbfb_unaccel_ops behind ...
-Daniel
> ---
> drivers/gpu/drm/gma500/framebuffer.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
> index 54d9876b5305..a56a6b53fac6 100644
> --- a/drivers/gpu/drm/gma500/framebuffer.c
> +++ b/drivers/gpu/drm/gma500/framebuffer.c
> @@ -177,7 +177,14 @@ static const struct fb_ops psbfb_ops = {
>
> static const struct fb_ops psbfb_roll_ops = {
> .owner = THIS_MODULE,
> - DRM_FB_HELPER_DEFAULT_OPS,
> + .fb_check_var = drm_fb_helper_check_var,
> + .fb_set_par = drm_fb_helper_set_par,
> + .fb_setcmap = drm_fb_helper_setcmap,
> + .fb_blank = drm_fb_helper_blank,
> + .fb_debug_enter = drm_fb_helper_debug_enter,
> + .fb_debug_leave = drm_fb_helper_debug_leave,
> + .fb_ioctl = drm_fb_helper_ioctl,
> +
> .fb_setcolreg = psbfb_setcolreg,
> .fb_fillrect = drm_fb_helper_cfb_fillrect,
> .fb_copyarea = drm_fb_helper_cfb_copyarea,
> --
> 2.27.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2020-10-27 9:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 19:41 [PATCH 1/4] drm/tilcdc: avoid 'make W=2' build failure Arnd Bergmann
2020-10-26 19:41 ` [PATCH 2/4] drm/imx: tve remove extraneous type qualifier Arnd Bergmann
2020-10-26 19:44 ` Nick Desaulniers
2020-10-27 14:56 ` Philipp Zabel
2020-10-26 19:41 ` [PATCH 3/4] drm/msm: fix -Woverride-init warning Arnd Bergmann
2020-10-26 20:52 ` [Freedreno] " abhinavk
2020-10-26 20:56 ` Stephen Boyd
2020-10-26 19:41 ` [PATCH 4/4] drm/gma500: avoid Woverride-init warning Arnd Bergmann
2020-10-27 9:33 ` Daniel Vetter [this message]
2020-10-27 9:54 ` Patrik Jakobsson
2020-10-27 16:49 ` Arnd Bergmann
2020-10-28 14:41 ` Patrik Jakobsson
2020-10-27 15:31 ` [PATCH 1/4] drm/tilcdc: avoid 'make W=2' build failure Jyri Sarha
2020-10-27 16:47 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027093350.GI401619@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=contact@stefanchrist.eu \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.velikov@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.laxminarayan.bharadiya@intel.com \
--cc=patrik.r.jakobsson@gmail.com \
--cc=paul.kocialkowski@bootlin.com \
--cc=rikard.falkeborn@gmail.com \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).