From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB874C55178 for ; Tue, 27 Oct 2020 15:31:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E87222275 for ; Tue, 27 Oct 2020 15:31:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603812686; bh=ozyLgpXHqosmv35bnuQ3dUi+EEKOVW8d1oUoxx9+eOk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=LxLHQQ3P74LF7Qx5ThLXu41qXYym+QGfgYWYHSBAT6rROa9ikInmZSh++55/KtYKw bmk28EuSy//3fhb+KN43L4R5LpUeeRHoXWmPgnEuqJ9vx2A7MewsH7VITEmJI3UI2h KGHGSux44j0iCRBlHc00lCIXqpweSeakaDJNDzdQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1799425AbgJ0PbZ (ORCPT ); Tue, 27 Oct 2020 11:31:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:36666 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1797162AbgJ0PVz (ORCPT ); Tue, 27 Oct 2020 11:21:55 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3D7C820728; Tue, 27 Oct 2020 15:21:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603812114; bh=ozyLgpXHqosmv35bnuQ3dUi+EEKOVW8d1oUoxx9+eOk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wsolK2ihHDkm394GLg82y+CU+yqhzsKotk8JkyU1TcFSVGXDSvGe0/OqX2oVkY2cm Ug8gZK2bEU0cE1lHVPcrjDmMzgRDRwCJO2AnTZzaDApte9uUWhGV4XuGtpJmo0jbYi TX1PPYldKF4z2sJ+5fe1UMDtjwjth0j3+F+VwA6M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, YueHaibing , Marc Zyngier , Lokesh Vutla , Sasha Levin Subject: [PATCH 5.9 097/757] irqchip/ti-sci-intr: Fix unsigned comparison to zero Date: Tue, 27 Oct 2020 14:45:47 +0100 Message-Id: <20201027135455.100196817@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing [ Upstream commit 8ddf1905a904ca86d71ca1c435e4b0b2a0b70df8 ] ti_sci_intr_xlate_irq() return -ENOENT on fail, p_hwirq should be int type. Fixes: a5b659bd4bc7 ("irqchip/ti-sci-intr: Add support for INTR being a parent to INTR") Signed-off-by: YueHaibing Signed-off-by: Marc Zyngier Acked-by: Lokesh Vutla Link: https://lore.kernel.org/r/20200826035321.18620-1-yuehaibing@huawei.com Signed-off-by: Sasha Levin --- drivers/irqchip/irq-ti-sci-intr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-ti-sci-intr.c b/drivers/irqchip/irq-ti-sci-intr.c index cbc1758228d9e..85a72b56177cf 100644 --- a/drivers/irqchip/irq-ti-sci-intr.c +++ b/drivers/irqchip/irq-ti-sci-intr.c @@ -137,8 +137,8 @@ static int ti_sci_intr_alloc_parent_irq(struct irq_domain *domain, struct ti_sci_intr_irq_domain *intr = domain->host_data; struct device_node *parent_node; struct irq_fwspec fwspec; - u16 out_irq, p_hwirq; - int err = 0; + int p_hwirq, err = 0; + u16 out_irq; out_irq = ti_sci_get_free_resource(intr->out_irqs); if (out_irq == TI_SCI_RESOURCE_NULL) -- 2.25.1