From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 688D5C55178 for ; Tue, 27 Oct 2020 16:48:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 19B5520790 for ; Tue, 27 Oct 2020 16:48:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603817282; bh=7rwh9ZMG+d1y23DyeDVmbYql2ny56E1HuVwnfG6azQI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vu9VRXI/XDphxyQXeIeYClK60I+6xSftQPgKlHyRLdYLmGajlP8UPHTOLXDqoYC71 QbSGb2neM4+JkQrRq9iruvzcbCgRKnEhwfZ7Y4sYf9L8yVdq1d7PlBQAG0dVXeiLYi qPtMMPp4Huh96QjY07suLFl68pZyUybO1ggj7n8k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1813085AbgJ0Qr7 (ORCPT ); Tue, 27 Oct 2020 12:47:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:34134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S368854AbgJ0PmC (ORCPT ); Tue, 27 Oct 2020 11:42:02 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E58792231B; Tue, 27 Oct 2020 15:42:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603813321; bh=7rwh9ZMG+d1y23DyeDVmbYql2ny56E1HuVwnfG6azQI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r0FoSyB4JozOfwDx1qldhFItra+6kJpmgapdrNgz2K8MRwuspI1SSroNhu5pi4Ogd l0G+I7ni8rQ6AcQmrDQEr5Ky5jlGrV0+B0K8Vqm+QsZUv8phPlrdWyhxmKiPQYheLA Bgys+T3NkarjHKG/p697HhCXJTBKj5dYABH8vgu8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nicholas Piggin , Michael Ellerman , Sasha Levin Subject: [PATCH 5.9 482/757] powerpc/64: fix irq replay pt_regs->softe value Date: Tue, 27 Oct 2020 14:52:12 +0100 Message-Id: <20201027135513.091249938@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nicholas Piggin [ Upstream commit 2b48e96be2f9f7151197fd25dc41487054bc6f5b ] Replayed interrupts get an "artificial" struct pt_regs constructed to pass to interrupt handler functions. This did not get the softe field set correctly, it's as though the interrupt has hit while irqs are disabled. It should be IRQS_ENABLED. This is possibly harmless, asynchronous handlers should not be testing if irqs were disabled, but it might be possible for example some code is shared with synchronous or NMI handlers, and it makes more sense if debug output looks at this. Fixes: 3282a3da25bd ("powerpc/64: Implement soft interrupt replay in C") Signed-off-by: Nicholas Piggin Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20200915114650.3980244-2-npiggin@gmail.com Signed-off-by: Sasha Levin --- arch/powerpc/kernel/irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c index 77019699606a5..3fdad93368858 100644 --- a/arch/powerpc/kernel/irq.c +++ b/arch/powerpc/kernel/irq.c @@ -214,7 +214,7 @@ void replay_soft_interrupts(void) struct pt_regs regs; ppc_save_regs(®s); - regs.softe = IRQS_ALL_DISABLED; + regs.softe = IRQS_ENABLED; again: if (IS_ENABLED(CONFIG_PPC_IRQ_SOFT_MASK_DEBUG)) -- 2.25.1