From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C681EC55179 for ; Tue, 27 Oct 2020 14:58:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 652B621527 for ; Tue, 27 Oct 2020 14:58:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603810726; bh=biabbz6vVQve8wqA4V1ide8c+rFTbecPsv24HC4oUuw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jhncrxCaomYi5fXexp0Mu98KM1HuzvW1yrNC3S6Z40C+SNaS4mSVueA1NK8zEE0if 0Mz/QXkC4wgnQSzkAmyxsdfqwWwH0gndlc3BxHM8aNKcqZ3B63uCYyXL+24Q3lPX8k 4SwAIOnMgcOs0lGmpwG07++c5i1+NdIiN+ZnUep8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1783940AbgJ0O6p (ORCPT ); Tue, 27 Oct 2020 10:58:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:50680 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1773109AbgJ0OvQ (ORCPT ); Tue, 27 Oct 2020 10:51:16 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5471F207DE; Tue, 27 Oct 2020 14:51:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603810275; bh=biabbz6vVQve8wqA4V1ide8c+rFTbecPsv24HC4oUuw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qiPHGoKWwHXOYfC/UkmASwowRnFNA2ozV3OM89gwUc1hEybeABttlnzeLHR21b0Xi 3yqIUqWH2z+jtKyjSckEV3skP3pVBaYlE+gfvxHW7V2SpPeqIAwzO5LYRWAHGf9LLw 6RYjuN2I48QURANArfMQPuBHBs6y4xsNBoVUpKdQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Roberto Sassu , Mimi Zohar Subject: [PATCH 5.8 075/633] ima: Dont ignore errors from crypto_shash_update() Date: Tue, 27 Oct 2020 14:46:58 +0100 Message-Id: <20201027135526.213145504@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135522.655719020@linuxfoundation.org> References: <20201027135522.655719020@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Roberto Sassu commit 60386b854008adc951c470067f90a2d85b5d520f upstream. Errors returned by crypto_shash_update() are not checked in ima_calc_boot_aggregate_tfm() and thus can be overwritten at the next iteration of the loop. This patch adds a check after calling crypto_shash_update() and returns immediately if the result is not zero. Cc: stable@vger.kernel.org Fixes: 3323eec921efd ("integrity: IMA as an integrity service provider") Signed-off-by: Roberto Sassu Signed-off-by: Mimi Zohar Signed-off-by: Greg Kroah-Hartman --- security/integrity/ima/ima_crypto.c | 2 ++ 1 file changed, 2 insertions(+) --- a/security/integrity/ima/ima_crypto.c +++ b/security/integrity/ima/ima_crypto.c @@ -829,6 +829,8 @@ static int ima_calc_boot_aggregate_tfm(c /* now accumulate with current aggregate */ rc = crypto_shash_update(shash, d.digest, crypto_shash_digestsize(tfm)); + if (rc != 0) + return rc; } /* * Extend cumulative digest over TPM registers 8-9, which contain