From: Fenghua Yu <fenghua.yu@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Stephane Eranian <eranian@google.com>,
Tony Luck <tony.luck@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Randy Dunlap <rdunlap@infradead.org>,
Ravi V Shankar <ravi.v.shankar@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [PATCH v3 2/2] x86/resctrl: Correct MBM total and local values
Date: Tue, 27 Oct 2020 18:02:56 +0000 [thread overview]
Message-ID: <20201027180256.GA3478584@otcwcpicx6.sc.intel.com> (raw)
In-Reply-To: <20201027175748.GJ15580@zn.tnic>
Hi, Boris,
On Tue, Oct 27, 2020 at 06:57:48PM +0100, Borislav Petkov wrote:
> On Wed, Oct 14, 2020 at 12:49:27AM +0000, Fenghua Yu wrote:
> > +static const struct mbm_correction_factor_table {
> > + u32 rmidthreshold;
> > + u64 cf;
> > +} mbm_cf_table[] = {
>
> That thing wants to be __initdata, AFAICT, since the only function
> touching it is __init.
>
> Made it so.
You are right. The correction value is read from this table only
once in __init. So this table should be __initdata.
Thank you very much for your review!
-Fenghua
next prev parent reply other threads:[~2020-10-27 18:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 0:49 [PATCH v3 0/2] x86/resctrl: Work around MBM errata Fenghua Yu
2020-10-14 0:49 ` [PATCH v3 1/2] Documentation: x86: Rename resctrl_ui.rst and add two errata to the file Fenghua Yu
2020-10-27 18:12 ` [tip: x86/cache] Documentation/x86: " tip-bot2 for Fenghua Yu
2020-10-14 0:49 ` [PATCH v3 2/2] x86/resctrl: Correct MBM total and local values Fenghua Yu
2020-10-27 17:57 ` Borislav Petkov
2020-10-27 18:02 ` Fenghua Yu [this message]
2020-10-27 18:12 ` [tip: x86/cache] " tip-bot2 for Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027180256.GA3478584@otcwcpicx6.sc.intel.com \
--to=fenghua.yu@intel.com \
--cc=bp@alien8.de \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=rdunlap@infradead.org \
--cc=reinette.chatre@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).