Hi Prashant, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on chrome-platform-linux/for-next] [also build test WARNING on linus/master v5.10-rc1 next-20201027] [cannot apply to linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Prashant-Malani/platform-chrome-cros_ec_typec-Register-partner-PD-information/20201022-045552 base: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next config: x86_64-randconfig-s022-20201027 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-56-gc09e8239-dirty # https://github.com/0day-ci/linux/commit/d95c360f8dc525bd78c299a987c1287867f766a2 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Prashant-Malani/platform-chrome-cros_ec_typec-Register-partner-PD-information/20201022-045552 git checkout d95c360f8dc525bd78c299a987c1287867f766a2 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot "sparse warnings: (new ones prefixed by >>)" >> drivers/platform/chrome/cros_ec_typec.c:698:5: sparse: sparse: symbol 'cros_typec_cmds_supported' was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org