From: Lukasz Luba <lukasz.luba@arm.com>
To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
vireshk@kernel.org, robh+dt@kernel.org
Cc: sboyd@kernel.org, nm@ti.com, rafael@kernel.org,
sudeep.holla@arm.com, daniel.lezcano@linaro.org,
Dietmar.Eggemann@arm.com, lukasz.luba@arm.com
Subject: [PATCH 2/4] OPP: Add support for parsing the 'opp-sustainable' property
Date: Wed, 28 Oct 2020 14:08:45 +0000 [thread overview]
Message-ID: <20201028140847.1018-3-lukasz.luba@arm.com> (raw)
In-Reply-To: <20201028140847.1018-1-lukasz.luba@arm.com>
Now that the OPP bindings are updated to include an optional
'opp-sustainable' property, add support to parse it from device tree and
store it as part of dev_pm_opp structure.
Also add and export an helper 'dev_pm_opp_get_sustainable()' that can be
used to get the sustainable OPP when present.
Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
drivers/opp/core.c | 26 ++++++++++++++++++++++++++
drivers/opp/of.c | 14 ++++++++++++++
drivers/opp/opp.h | 3 +++
include/linux/pm_opp.h | 6 ++++++
4 files changed, 49 insertions(+)
diff --git a/drivers/opp/core.c b/drivers/opp/core.c
index 9915e8487f0b..bb1e68b96d0e 100644
--- a/drivers/opp/core.c
+++ b/drivers/opp/core.c
@@ -299,6 +299,32 @@ unsigned long dev_pm_opp_get_suspend_opp_freq(struct device *dev)
}
EXPORT_SYMBOL_GPL(dev_pm_opp_get_suspend_opp_freq);
+/**
+ * dev_pm_opp_get_sustainable_opp_freq() - Get frequency of sustainable opp
+ * in Hz
+ * @dev: device for which we do this operation
+ *
+ * Return: This function returns the frequency of the OPP marked as
+ * sustainable_opp if one is available, else returns 0;
+ */
+unsigned long dev_pm_opp_get_sustainable_opp_freq(struct device *dev)
+{
+ struct opp_table *opp_table;
+ unsigned long freq = 0;
+
+ opp_table = _find_opp_table(dev);
+ if (IS_ERR(opp_table))
+ return 0;
+
+ if (opp_table->sustainable_opp && opp_table->sustainable_opp->available)
+ freq = dev_pm_opp_get_freq(opp_table->sustainable_opp);
+
+ dev_pm_opp_put_opp_table(opp_table);
+
+ return freq;
+}
+EXPORT_SYMBOL_GPL(dev_pm_opp_get_sustainable_opp_freq);
+
int _get_opp_count(struct opp_table *opp_table)
{
struct dev_pm_opp *opp;
diff --git a/drivers/opp/of.c b/drivers/opp/of.c
index 9faeb83e4b32..1f6b19bb1a95 100644
--- a/drivers/opp/of.c
+++ b/drivers/opp/of.c
@@ -815,6 +815,20 @@ static struct dev_pm_opp *_opp_add_static_v2(struct opp_table *opp_table,
}
}
+ if (of_property_read_bool(np, "opp-sustainable")) {
+ if (opp_table->sustainable_opp) {
+ /* Pick the OPP with higher rate as sustainable OPP */
+ if (new_opp->rate > opp_table->sustainable_opp->rate) {
+ opp_table->sustainable_opp->sustainable = false;
+ new_opp->sustainable = true;
+ opp_table->sustainable_opp = new_opp;
+ }
+ } else {
+ new_opp->sustainable = true;
+ opp_table->sustainable_opp = new_opp;
+ }
+ }
+
if (new_opp->clock_latency_ns > opp_table->clock_latency_ns_max)
opp_table->clock_latency_ns_max = new_opp->clock_latency_ns;
diff --git a/drivers/opp/opp.h b/drivers/opp/opp.h
index ebd930e0b3ca..45288ccbb295 100644
--- a/drivers/opp/opp.h
+++ b/drivers/opp/opp.h
@@ -56,6 +56,7 @@ extern struct list_head opp_tables;
* @dynamic: not-created from static DT entries.
* @turbo: true if turbo (boost) OPP
* @suspend: true if suspend OPP
+ * @sustainable: true if sustainable OPP
* @pstate: Device's power domain's performance state.
* @rate: Frequency in hertz
* @level: Performance level
@@ -78,6 +79,7 @@ struct dev_pm_opp {
bool dynamic;
bool turbo;
bool suspend;
+ bool sustainable;
unsigned int pstate;
unsigned long rate;
unsigned int level;
@@ -183,6 +185,7 @@ struct opp_table {
unsigned int parsed_static_opps;
enum opp_table_access shared_opp;
struct dev_pm_opp *suspend_opp;
+ struct dev_pm_opp *sustainable_opp;
struct mutex genpd_virt_dev_lock;
struct device **genpd_virt_devs;
diff --git a/include/linux/pm_opp.h b/include/linux/pm_opp.h
index dbb484524f82..363d5a2c1ef3 100644
--- a/include/linux/pm_opp.h
+++ b/include/linux/pm_opp.h
@@ -106,6 +106,7 @@ unsigned long dev_pm_opp_get_max_clock_latency(struct device *dev);
unsigned long dev_pm_opp_get_max_volt_latency(struct device *dev);
unsigned long dev_pm_opp_get_max_transition_latency(struct device *dev);
unsigned long dev_pm_opp_get_suspend_opp_freq(struct device *dev);
+unsigned long dev_pm_opp_get_sustainable_opp_freq(struct device *dev);
struct dev_pm_opp *dev_pm_opp_find_freq_exact(struct device *dev,
unsigned long freq,
@@ -215,6 +216,11 @@ static inline unsigned long dev_pm_opp_get_suspend_opp_freq(struct device *dev)
return 0;
}
+static inline unsigned long dev_pm_opp_get_sustainable_opp_freq(struct device *dev)
+{
+ return 0;
+}
+
static inline struct dev_pm_opp *dev_pm_opp_find_freq_exact(struct device *dev,
unsigned long freq, bool available)
{
--
2.17.1
next prev parent reply other threads:[~2020-10-28 22:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 14:08 [PATCH 0/4] Add sustainable OPP concept Lukasz Luba
2020-10-28 14:08 ` [PATCH 1/4] dt-bindings: opp: Introduce opp-sustainable bindings Lukasz Luba
2020-10-28 21:47 ` Nishanth Menon
2020-10-29 10:04 ` Lukasz Luba
2020-10-29 12:59 ` Nishanth Menon
2020-10-29 13:33 ` Lukasz Luba
2020-10-29 13:49 ` Nishanth Menon
2020-10-29 14:20 ` Lukasz Luba
2020-10-30 19:34 ` Rob Herring
2020-11-02 8:40 ` Lukasz Luba
2020-10-28 14:08 ` Lukasz Luba [this message]
2020-10-30 11:47 ` [PATCH 2/4] OPP: Add support for parsing the 'opp-sustainable' property Quentin Perret
2020-10-30 12:53 ` Lukasz Luba
2020-10-28 14:08 ` [PATCH 3/4] OPP: Add dev_pm_opp_set_sustainable_opp_freq() Lukasz Luba
2020-10-28 14:08 ` [PATCH 4/4] firmware: arm_scmi/perf: Mark sustainable OPP Lukasz Luba
2020-10-29 7:40 ` [PATCH 0/4] Add sustainable OPP concept Viresh Kumar
2020-10-29 7:53 ` Viresh Kumar
2020-10-29 9:56 ` Lukasz Luba
2020-10-30 8:29 ` Viresh Kumar
2020-10-30 9:19 ` Lukasz Luba
2020-10-30 9:52 ` Viresh Kumar
2020-10-30 10:56 ` Lukasz Luba
2020-10-30 11:17 ` Viresh Kumar
2020-10-30 12:40 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028140847.1018-3-lukasz.luba@arm.com \
--to=lukasz.luba@arm.com \
--cc=Dietmar.Eggemann@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).