From: Hui Su <sh_def@163.com>
To: Michal Hocko <mhocko@suse.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, sh_def@163.com
Subject: [PATCH v3] mm/oom_kill: remove comment and rename is_dump_unreclaim_slabs()
Date: Wed, 28 Oct 2020 23:31:41 +0800 [thread overview]
Message-ID: <20201028153141.GB77196@rlk> (raw)
In-Reply-To: <20201027192322.GA20500@dhcp22.suse.cz>
Comment for is_dump_unreclaim_slabs is not really clear whether it is
meant to instruct how to use the function or whether it is an outdated
information of the past implementation of the function. it doesn't realy
help that is_dump_unreclaim_slabs is hard to grasp on its own.
Rename the helper to should_dump_unreclaim_slabs which should make it
clear what it is meant to do and drop the comment as the purpose
should be pretty evident now.
Signed-off-by: Hui Su <sh_def@163.com>
Acked-by: Michal Hocko <mhocko@suse.com>
---
mm/oom_kill.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index 8b84661a6410..d181e24d7193 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -170,11 +170,7 @@ static bool oom_unkillable_task(struct task_struct *p)
return false;
}
-/*
- * Print out unreclaimble slabs info when unreclaimable slabs amount is greater
- * than all user memory (LRU pages)
- */
-static bool is_dump_unreclaim_slabs(void)
+static bool should_dump_unreclaim_slabs(void)
{
unsigned long nr_lru;
@@ -463,7 +459,7 @@ static void dump_header(struct oom_control *oc, struct task_struct *p)
mem_cgroup_print_oom_meminfo(oc->memcg);
else {
show_mem(SHOW_MEM_FILTER_NODES, oc->nodemask);
- if (is_dump_unreclaim_slabs())
+ if (should_dump_unreclaim_slabs())
dump_unreclaimable_slab();
}
if (sysctl_oom_dump_tasks)
--
2.29.0
next prev parent reply other threads:[~2020-10-28 22:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 14:45 [PATCH v2] mm/oom_kill.c: remove the unmatched comments Hui Su
2020-10-27 14:58 ` Michal Hocko
2020-10-27 15:11 ` Hui Su
2020-10-27 19:23 ` Michal Hocko
2020-10-28 15:31 ` Hui Su [this message]
2020-10-28 21:53 ` [PATCH v3] mm/oom_kill: remove comment and rename is_dump_unreclaim_slabs() Andrew Morton
2020-10-29 7:51 ` Michal Hocko
2020-10-30 18:27 ` [PATCH v4] mm/oom_kill: change " Hui Su
2020-11-02 7:28 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028153141.GB77196@rlk \
--to=sh_def@163.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).