linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Hector Yuan <hector.yuan@mediatek.com>,
	rjw@rjwysocki.net, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: cpus: Document 'qcom,freq-domain' property
Date: Wed, 28 Oct 2020 10:46:37 -0500	[thread overview]
Message-ID: <20201028154637.GB4065833@bogus> (raw)
In-Reply-To: <20201021105037.vrqgmvbxxhccch33@vireshk-i7>

On Wed, Oct 21, 2020 at 04:20:37PM +0530, Viresh Kumar wrote:
> On 21-10-20, 15:29, Manivannan Sadhasivam wrote:
> > Hi,
> > 
> > On Wed, Oct 21, 2020 at 10:36:43AM +0800, Hector Yuan wrote:
> > > Hi, Manivannan
> > > 
> > > On Tue, 2020-10-20 at 21:09 +0530, Manivannan Sadhasivam wrote:
> > > > Add devicetree documentation for 'qcom,freq-domain' property specific
> > > > to Qualcomm CPUs. This property is used to reference the CPUFREQ node
> > > > along with Domain ID (0/1).
> > > > 
> > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > > ---
> > > >  Documentation/devicetree/bindings/arm/cpus.yaml | 6 ++++++
> > > >  1 file changed, 6 insertions(+)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
> > > > index 1222bf1831fa..f40564bf004f 100644
> > > > --- a/Documentation/devicetree/bindings/arm/cpus.yaml
> > > > +++ b/Documentation/devicetree/bindings/arm/cpus.yaml
> > > > @@ -290,6 +290,12 @@ properties:
> > > >  
> > > >        * arm/msm/qcom,kpss-acc.txt
> > > >  
> > > > +  qcom,freq-domain:
> > > Do you mind to change "qcom, freq-domain" to common naming? or drop the
> > > prefix. So that we can use this CPU node and map it to each freq-domain.
> > > Thanks a lot. 
> > 
> > I can do that but did the domain value match for other platforms as well?
> 
> I am not sure if you can. The code needs to be backward compatible so it can
> support all devices shipped with older bootloaders and latest kernels. And so
> changing the bindings isn't a good idea normally.

It can be done. We'd need to do the following:

- schema defines the common property/binding.
- The kernel supports both names and that is backported to stable.
- Update all the Qcom dts files to the new binding

Whether we actually do that or not, I'd like to keep the option open. 
Aligning the current proposals should be possible. My concern is more 
about what's the next addition and non-cpu device support.

Rob

  reply	other threads:[~2020-10-28 22:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-20 15:39 [PATCH v3 1/2] dt-bindings: arm: cpus: Document 'qcom,freq-domain' property Manivannan Sadhasivam
2020-10-20 15:39 ` [PATCH v3 2/2] dt-bindings: cpufreq: cpufreq-qcom-hw: Convert to YAML bindings Manivannan Sadhasivam
2020-10-21  2:36 ` [PATCH v3 1/2] dt-bindings: arm: cpus: Document 'qcom,freq-domain' property Hector Yuan
2020-10-21  9:59   ` Manivannan Sadhasivam
2020-10-21 10:50     ` Viresh Kumar
2020-10-28 15:46       ` Rob Herring [this message]
2020-12-08 15:43         ` Manivannan Sadhasivam
2020-10-26 14:32 ` Rob Herring
2020-10-26 14:51   ` Bjorn Andersson
2020-10-28 15:38     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201028154637.GB4065833@bogus \
    --to=robh@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hector.yuan@mediatek.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=rjw@rjwysocki.net \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).