From: Greg Kroah-Hartman <gregkh@google.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] proc "single files": switch to ->read_iter
Date: Wed, 28 Oct 2020 19:35:25 +0100 [thread overview]
Message-ID: <20201028183525.GB2957431@kroah.com> (raw)
In-Reply-To: <20201028183359.GA2957431@kroah.com>
Implement ->read_iter for all proc "single files" so that more bionic
tests cases can pass when they call splice() on other fun files like
/proc/version
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
fs/proc/generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/proc/generic.c b/fs/proc/generic.c
index 2f9fa179194d..f81327673f49 100644
--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -621,7 +621,7 @@ static int proc_single_open(struct inode *inode, struct file *file)
static const struct proc_ops proc_single_ops = {
/* not permanent -- can call into arbitrary ->single_show */
.proc_open = proc_single_open,
- .proc_read = seq_read,
+ .proc_read_iter = seq_read_iter,
.proc_lseek = seq_lseek,
.proc_release = single_release,
};
--
2.29.1
prev parent reply other threads:[~2020-10-28 22:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-25 22:40 Linux 5.10-rc1 Linus Torvalds
2020-10-25 23:43 ` linux-next: stats Stephen Rothwell
2020-10-27 6:48 ` problems with splice from /proc (was Linux 5.10-rc1) Greg KH
2020-10-27 7:49 ` Christoph Hellwig
2020-10-27 7:55 ` Greg KH
2020-10-27 8:07 ` Christoph Hellwig
2020-10-27 8:14 ` Greg KH
2020-10-27 8:14 ` Christoph Hellwig
2020-10-27 9:17 ` Greg KH
2020-10-27 16:32 ` Christoph Hellwig
2020-10-27 17:43 ` Greg KH
2020-10-28 16:00 ` Greg KH
2020-10-28 18:33 ` Greg KH
2020-10-28 18:34 ` Christoph Hellwig
2020-10-28 18:35 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028183525.GB2957431@kroah.com \
--to=gregkh@google.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).