From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E472C55179 for ; Thu, 29 Oct 2020 12:42:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5A22206DD for ; Thu, 29 Oct 2020 12:42:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726171AbgJ2Mme (ORCPT ); Thu, 29 Oct 2020 08:42:34 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:52022 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725355AbgJ2Mmc (ORCPT ); Thu, 29 Oct 2020 08:42:32 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kY7Fg-0049fs-Le; Thu, 29 Oct 2020 13:42:00 +0100 Date: Thu, 29 Oct 2020 13:42:00 +0100 From: Andrew Lunn To: Pavana Sharma Cc: davem@davemloft.net, f.fainelli@gmail.com, gregkh@linuxfoundation.org, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, vivien.didelot@gmail.com, marek.behun@nic.cz, ashkan.boldaji@digi.com Subject: Re: [PATCH v6 2/4] net: phy: Add 5GBASER interface mode Message-ID: <20201029124200.GJ933237@lunn.ch> References: <9b93cc79d7cc07ee77808150ca76c9d243c8ca60.1603944740.git.pavana.sharma@digi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9b93cc79d7cc07ee77808150ca76c9d243c8ca60.1603944740.git.pavana.sharma@digi.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2020 at 03:42:00PM +1000, Pavana Sharma wrote: > Add new mode supported by MV88E6393 family. Hi Pavana I asked you to add kerneldoc for this new value, but you have not added it. Please compile your code with W=1, and you should see the warning. Andrew