linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RESEND PATCH] KEYS: asymmetric: Fix kerneldoc
@ 2020-10-29 15:48 Krzysztof Kozlowski
  2020-10-29 16:38 ` Ben Boeckel
  2020-10-30  8:08 ` Jarkko Sakkinen
  0 siblings, 2 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-29 15:48 UTC (permalink / raw)
  To: David Howells, Herbert Xu, David S. Miller, keyrings,
	linux-crypto, linux-kernel
  Cc: Krzysztof Kozlowski, Randy Dunlap

Fix W=1 compile warnings (invalid kerneldoc):

    crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid1' not described in 'asymmetric_key_id_same'
    crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid2' not described in 'asymmetric_key_id_same'
    crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_1' description in 'asymmetric_key_id_same'
    crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_2' description in 'asymmetric_key_id_same'

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
---
 crypto/asymmetric_keys/asymmetric_type.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/crypto/asymmetric_keys/asymmetric_type.c b/crypto/asymmetric_keys/asymmetric_type.c
index 33e77d846caa..ad8af3d70ac0 100644
--- a/crypto/asymmetric_keys/asymmetric_type.c
+++ b/crypto/asymmetric_keys/asymmetric_type.c
@@ -152,7 +152,8 @@ EXPORT_SYMBOL_GPL(asymmetric_key_generate_id);
 
 /**
  * asymmetric_key_id_same - Return true if two asymmetric keys IDs are the same.
- * @kid_1, @kid_2: The key IDs to compare
+ * @kid1: The key ID to compare
+ * @kid2: The key ID to compare
  */
 bool asymmetric_key_id_same(const struct asymmetric_key_id *kid1,
 			    const struct asymmetric_key_id *kid2)
@@ -168,7 +169,8 @@ EXPORT_SYMBOL_GPL(asymmetric_key_id_same);
 /**
  * asymmetric_key_id_partial - Return true if two asymmetric keys IDs
  * partially match
- * @kid_1, @kid_2: The key IDs to compare
+ * @kid1: The key ID to compare
+ * @kid2: The key ID to compare
  */
 bool asymmetric_key_id_partial(const struct asymmetric_key_id *kid1,
 			       const struct asymmetric_key_id *kid2)
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [RESEND PATCH] KEYS: asymmetric: Fix kerneldoc
  2020-10-29 15:48 [RESEND PATCH] KEYS: asymmetric: Fix kerneldoc Krzysztof Kozlowski
@ 2020-10-29 16:38 ` Ben Boeckel
  2020-10-30  8:08 ` Jarkko Sakkinen
  1 sibling, 0 replies; 6+ messages in thread
From: Ben Boeckel @ 2020-10-29 16:38 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: David Howells, Herbert Xu, David S. Miller, keyrings,
	linux-crypto, linux-kernel, Randy Dunlap

On Thu, Oct 29, 2020 at 16:48:30 +0100, Krzysztof Kozlowski wrote:
> Fix W=1 compile warnings (invalid kerneldoc):
> 
>     crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid1' not described in 'asymmetric_key_id_same'
>     crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid2' not described in 'asymmetric_key_id_same'
>     crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_1' description in 'asymmetric_key_id_same'
>     crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_2' description in 'asymmetric_key_id_same'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>

Reviewed-by: Ben Boeckel <mathstuf@gmail.com>

--Ben

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [RESEND PATCH] KEYS: asymmetric: Fix kerneldoc
  2020-10-29 15:48 [RESEND PATCH] KEYS: asymmetric: Fix kerneldoc Krzysztof Kozlowski
  2020-10-29 16:38 ` Ben Boeckel
@ 2020-10-30  8:08 ` Jarkko Sakkinen
  1 sibling, 0 replies; 6+ messages in thread
From: Jarkko Sakkinen @ 2020-10-30  8:08 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: David Howells, Herbert Xu, David S. Miller, keyrings,
	linux-crypto, linux-kernel, Randy Dunlap

On Thu, Oct 29, 2020 at 04:48:30PM +0100, Krzysztof Kozlowski wrote:
> Fix W=1 compile warnings (invalid kerneldoc):
> 
>     crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid1' not described in 'asymmetric_key_id_same'
>     crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid2' not described in 'asymmetric_key_id_same'
>     crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_1' description in 'asymmetric_key_id_same'
>     crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_2' description in 'asymmetric_key_id_same'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> ---

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@iki.fi>

>  crypto/asymmetric_keys/asymmetric_type.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/crypto/asymmetric_keys/asymmetric_type.c b/crypto/asymmetric_keys/asymmetric_type.c
> index 33e77d846caa..ad8af3d70ac0 100644
> --- a/crypto/asymmetric_keys/asymmetric_type.c
> +++ b/crypto/asymmetric_keys/asymmetric_type.c
> @@ -152,7 +152,8 @@ EXPORT_SYMBOL_GPL(asymmetric_key_generate_id);
>  
>  /**
>   * asymmetric_key_id_same - Return true if two asymmetric keys IDs are the same.
> - * @kid_1, @kid_2: The key IDs to compare
> + * @kid1: The key ID to compare
> + * @kid2: The key ID to compare
>   */
>  bool asymmetric_key_id_same(const struct asymmetric_key_id *kid1,
>  			    const struct asymmetric_key_id *kid2)
> @@ -168,7 +169,8 @@ EXPORT_SYMBOL_GPL(asymmetric_key_id_same);
>  /**
>   * asymmetric_key_id_partial - Return true if two asymmetric keys IDs
>   * partially match
> - * @kid_1, @kid_2: The key IDs to compare
> + * @kid1: The key ID to compare
> + * @kid2: The key ID to compare
>   */
>  bool asymmetric_key_id_partial(const struct asymmetric_key_id *kid1,
>  			       const struct asymmetric_key_id *kid2)
> -- 
> 2.25.1
> 
> 

/Jarkko

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [RESEND PATCH] KEYS: asymmetric: Fix kerneldoc
  2020-08-30 14:56 ` Krzysztof Kozlowski
@ 2020-08-30 15:01   ` Randy Dunlap
  0 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2020-08-30 15:01 UTC (permalink / raw)
  To: Krzysztof Kozlowski, David Howells, Herbert Xu, David S. Miller,
	keyrings, linux-crypto, linux-kernel

On 8/30/20 7:56 AM, Krzysztof Kozlowski wrote:
> On Wed, Aug 19, 2020 at 07:52:12PM +0200, Krzysztof Kozlowski wrote:
>> Fix W=1 compile warnings (invalid kerneldoc):
>>
>>     crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid1' not described in 'asymmetric_key_id_same'
>>     crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid2' not described in 'asymmetric_key_id_same'
>>     crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_1' description in 'asymmetric_key_id_same'
>>     crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_2' description in 'asymmetric_key_id_same'
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>> ---
>>  crypto/asymmetric_keys/asymmetric_type.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> Hi David, Herbert,
> 
> Any comments here?
> 
> Best regards,
> Krzysztof

LGTM.  Thanks.

Acked-by: Randy Dunlap <rdunlap@infradead.org>

-- 
~Randy

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [RESEND PATCH] KEYS: asymmetric: Fix kerneldoc
  2020-08-19 17:52 Krzysztof Kozlowski
@ 2020-08-30 14:56 ` Krzysztof Kozlowski
  2020-08-30 15:01   ` Randy Dunlap
  0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-30 14:56 UTC (permalink / raw)
  To: David Howells, Herbert Xu, David S. Miller, keyrings,
	linux-crypto, linux-kernel

On Wed, Aug 19, 2020 at 07:52:12PM +0200, Krzysztof Kozlowski wrote:
> Fix W=1 compile warnings (invalid kerneldoc):
> 
>     crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid1' not described in 'asymmetric_key_id_same'
>     crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid2' not described in 'asymmetric_key_id_same'
>     crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_1' description in 'asymmetric_key_id_same'
>     crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_2' description in 'asymmetric_key_id_same'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  crypto/asymmetric_keys/asymmetric_type.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Hi David, Herbert,

Any comments here?

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [RESEND PATCH] KEYS: asymmetric: Fix kerneldoc
@ 2020-08-19 17:52 Krzysztof Kozlowski
  2020-08-30 14:56 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-19 17:52 UTC (permalink / raw)
  To: David Howells, Herbert Xu, David S. Miller, keyrings,
	linux-crypto, linux-kernel
  Cc: Krzysztof Kozlowski

Fix W=1 compile warnings (invalid kerneldoc):

    crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid1' not described in 'asymmetric_key_id_same'
    crypto/asymmetric_keys/asymmetric_type.c:160: warning: Function parameter or member 'kid2' not described in 'asymmetric_key_id_same'
    crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_1' description in 'asymmetric_key_id_same'
    crypto/asymmetric_keys/asymmetric_type.c:160: warning: Excess function parameter 'kid_2' description in 'asymmetric_key_id_same'

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 crypto/asymmetric_keys/asymmetric_type.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/crypto/asymmetric_keys/asymmetric_type.c b/crypto/asymmetric_keys/asymmetric_type.c
index 33e77d846caa..ad8af3d70ac0 100644
--- a/crypto/asymmetric_keys/asymmetric_type.c
+++ b/crypto/asymmetric_keys/asymmetric_type.c
@@ -152,7 +152,8 @@ EXPORT_SYMBOL_GPL(asymmetric_key_generate_id);
 
 /**
  * asymmetric_key_id_same - Return true if two asymmetric keys IDs are the same.
- * @kid_1, @kid_2: The key IDs to compare
+ * @kid1: The key ID to compare
+ * @kid2: The key ID to compare
  */
 bool asymmetric_key_id_same(const struct asymmetric_key_id *kid1,
 			    const struct asymmetric_key_id *kid2)
@@ -168,7 +169,8 @@ EXPORT_SYMBOL_GPL(asymmetric_key_id_same);
 /**
  * asymmetric_key_id_partial - Return true if two asymmetric keys IDs
  * partially match
- * @kid_1, @kid_2: The key IDs to compare
+ * @kid1: The key ID to compare
+ * @kid2: The key ID to compare
  */
 bool asymmetric_key_id_partial(const struct asymmetric_key_id *kid1,
 			       const struct asymmetric_key_id *kid2)
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-10-30  8:08 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-29 15:48 [RESEND PATCH] KEYS: asymmetric: Fix kerneldoc Krzysztof Kozlowski
2020-10-29 16:38 ` Ben Boeckel
2020-10-30  8:08 ` Jarkko Sakkinen
  -- strict thread matches above, loose matches on Subject: below --
2020-08-19 17:52 Krzysztof Kozlowski
2020-08-30 14:56 ` Krzysztof Kozlowski
2020-08-30 15:01   ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).