From: Krzysztof Kozlowski <krzk@kernel.org>
To: Coiby Xu <coiby.xu@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
"open list:MAXIM PMIC AND MUIC DRIVERS FOR EXYNOS BASED BO..."
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/9] mfd: maxim: remove unnecessary CONFIG_PM_SLEEP
Date: Thu, 29 Oct 2020 19:32:26 +0100 [thread overview]
Message-ID: <20201029183226.GA88922@kozik-lap> (raw)
In-Reply-To: <20201029100647.233361-1-coiby.xu@gmail.com>
On Thu, Oct 29, 2020 at 06:06:39PM +0800, Coiby Xu wrote:
> SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.
I don't quite get what did you mean by "took good care". This should
cause warnings of unused structure. Comment applies to other patches as
well.
Also, the title prefix is: "mfd: max77686:"
Best regards,
Krzysztof
>
> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
> ---
> drivers/mfd/max77686.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
> index 71faf503844b..8c701f8a9dd5 100644
> --- a/drivers/mfd/max77686.c
> +++ b/drivers/mfd/max77686.c
> @@ -227,7 +227,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c)
> return 0;
> }
>
> -#ifdef CONFIG_PM_SLEEP
> static int max77686_suspend(struct device *dev)
> {
> struct i2c_client *i2c = to_i2c_client(dev);
> @@ -262,7 +261,6 @@ static int max77686_resume(struct device *dev)
>
> return 0;
> }
> -#endif /* CONFIG_PM_SLEEP */
>
> static SIMPLE_DEV_PM_OPS(max77686_pm, max77686_suspend, max77686_resume);
>
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-10-29 18:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 10:06 [PATCH 1/9] mfd: maxim: remove unnecessary CONFIG_PM_SLEEP Coiby Xu
2020-10-29 10:06 ` [PATCH 2/9] mfd: motorola-cpcap: " Coiby Xu
2020-10-29 10:06 ` [PATCH 3/9] mfd: intel_soc_pmic: " Coiby Xu
2020-10-29 11:00 ` Andy Shevchenko
2020-10-29 14:29 ` Coiby Xu
2020-10-29 15:27 ` Lee Jones
2020-10-29 17:04 ` Andy Shevchenko
2020-10-30 14:22 ` Coiby Xu
2020-10-30 14:34 ` Andy Shevchenko
2020-11-02 8:39 ` Lee Jones
2020-11-02 10:26 ` Andy Shevchenko
2020-11-02 10:51 ` Lee Jones
2020-10-29 10:06 ` [PATCH 4/9] mfd: max77620: " Coiby Xu
2020-10-29 10:06 ` [PATCH 5/9] mfd: stpmic1: " Coiby Xu
2020-10-29 10:06 ` [PATCH 6/9] mfd: stmfx: " Coiby Xu
2020-10-29 22:36 ` kernel test robot
2020-10-29 10:06 ` [PATCH 7/9] mfd: sec: " Coiby Xu
2020-10-29 10:06 ` [PATCH 8/9] mfd: max14577: " Coiby Xu
2020-10-29 10:06 ` [PATCH 9/9] mfd: sprd-sc27xx-spi: " Coiby Xu
2020-10-30 4:02 ` Chunyan Zhang
2020-10-30 14:53 ` Coiby Xu
2020-10-29 18:32 ` Krzysztof Kozlowski [this message]
2020-10-30 15:01 ` [PATCH 1/9] mfd: maxim: " Coiby Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029183226.GA88922@kozik-lap \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=coiby.xu@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).