From: Krzysztof Kozlowski <krzk@kernel.org>
To: Adam Ford <aford173@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
arm-soc <linux-arm-kernel@lists.infradead.org>,
aford@beaconemedded.com, Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: imx8mm: Add support for micfil
Date: Thu, 29 Oct 2020 20:24:36 +0100 [thread overview]
Message-ID: <20201029192436.GB308501@kozik-lap> (raw)
In-Reply-To: <CAHCN7xKBx_YXCGSUJWO3YCaGfx4oc7iuv6S4qi500_NjV9pW=w@mail.gmail.com>
On Wed, Oct 28, 2020 at 07:10:37AM -0500, Adam Ford wrote:
> On Tue, May 19, 2020 at 8:03 PM Shawn Guo <shawnguo@kernel.org> wrote:
> >
> > On Sat, May 02, 2020 at 07:59:48AM -0500, Adam Ford wrote:
> > > The i.MX8M Mini has supports the MICFIL digital interface.
> > > It's a 16-bit audio signal from a PDM microphone bitstream.
> > > The driver is already in the kernel, but the node is missing.
> > >
> > > This patch adds the micfil node.
> > >
> > > Signed-off-by: Adam Ford <aford173@gmail.com>
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > index c63685ae80ee..d46e727fc362 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > @@ -339,6 +339,25 @@ sai6: sai@30060000 {
> > > status = "disabled";
> > > };
> > >
> > > + micfil: micfil@30080000 {
> >
> > Find a generic node name, audio-controller maybe?
>
> The SAI's nodes are called SAI@xxxx
>
> If that's a deal-breaker, I can push a V3.
>
> I didn't see anyone from the device tree side comment, and the device
> tree binding doc states 'micfil@xxxxxx' so I used what was documented
> in the fsl,micfil.txt
Hi,
The example in the binding is not a binding itself. It can be misleading
or even incorrect and it is not a reason to use such in DTS.
Could be also audio-codec but it is not accurate (as it is only from the
microphone to digital).
Shawn's proposal is the best, I think.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-10-29 19:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 12:59 [PATCH] arm64: defconfig: Enable some audio drivers on i.MX8M Mini Adam Ford
2020-05-02 12:59 ` [PATCH] arm64: dts: imx8mm: Add support for micfil Adam Ford
2020-05-20 1:03 ` Shawn Guo
2020-10-28 12:10 ` Adam Ford
2020-10-29 19:24 ` Krzysztof Kozlowski [this message]
2020-05-20 1:02 ` [PATCH] arm64: defconfig: Enable some audio drivers on i.MX8M Mini Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029192436.GB308501@kozik-lap \
--to=krzk@kernel.org \
--cc=aford173@gmail.com \
--cc=aford@beaconemedded.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).