From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Chris Ye <lzye@google.com>
Cc: Alexandru Ardelean <alexandru.ardelean@analog.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, trivial@kernel.org,
linux-input@vger.kernel.org, linzhao.ye@gmail.com
Subject: Re: [PATCH] Add devices for HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE
Date: Thu, 29 Oct 2020 13:39:54 -0700 [thread overview]
Message-ID: <20201029203954.GF2547185@dtor-ws> (raw)
In-Reply-To: <20201029194714.1613308-1-lzye@google.com>
Hi Chris,
On Thu, Oct 29, 2020 at 12:47:14PM -0700, Chris Ye wrote:
> Kernel 5.4 introduces HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE, devices
> need to be set explicitly with this flag.
>
> Signed-off-by: Chris Ye <lzye@google.com>
The format of the patches looks good now, but you want to make sure you
send your patches to the right folks:
dtor@dtor-ws:~/kernel/work $ ./scripts/get_maintainer.pl drivers/hid/hid-ids.h
Jiri Kosina <jikos@kernel.org> (maintainer:HID CORE LAYER)
Benjamin Tissoires <benjamin.tissoires@redhat.com> (maintainer:HID CORE LAYER)
linux-input@vger.kernel.org (open list:HID CORE LAYER)
linux-kernel@vger.kernel.org (open list)
Thanks.
> ---
> drivers/hid/hid-ids.h | 4 ++++
> drivers/hid/hid-quirks.c | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 74be76e848bf..cf55dca494f3 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -449,6 +449,10 @@
> #define USB_VENDOR_ID_FRUCTEL 0x25B6
> #define USB_DEVICE_ID_GAMETEL_MT_MODE 0x0002
>
> +#define USB_VENDOR_ID_GAMEVICE 0x27F8
> +#define USB_DEVICE_ID_GAMEVICE_GV186 0x0BBE
> +#define USB_DEVICE_ID_GAMEVICE_KISHI 0x0BBF
> +
> #define USB_VENDOR_ID_GAMERON 0x0810
> #define USB_DEVICE_ID_GAMERON_DUAL_PSX_ADAPTOR 0x0001
> #define USB_DEVICE_ID_GAMERON_DUAL_PCS_ADAPTOR 0x0002
> diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c
> index 0440e2f6e8a3..36d94e3485e3 100644
> --- a/drivers/hid/hid-quirks.c
> +++ b/drivers/hid/hid-quirks.c
> @@ -84,6 +84,10 @@ static const struct hid_device_id hid_quirks[] = {
> { HID_USB_DEVICE(USB_VENDOR_ID_FREESCALE, USB_DEVICE_ID_FREESCALE_MX28), HID_QUIRK_NOGET },
> { HID_USB_DEVICE(USB_VENDOR_ID_FUTABA, USB_DEVICE_ID_LED_DISPLAY), HID_QUIRK_NO_INIT_REPORTS },
> { HID_USB_DEVICE(USB_VENDOR_ID_GREENASIA, USB_DEVICE_ID_GREENASIA_DUAL_USB_JOYPAD), HID_QUIRK_MULTI_INPUT },
> + { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_GAMEVICE, USB_DEVICE_ID_GAMEVICE_GV186),
> + HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE },
> + { HID_USB_DEVICE(USB_VENDOR_ID_GAMEVICE, USB_DEVICE_ID_GAMEVICE_KISHI),
> + HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE },
> { HID_USB_DEVICE(USB_VENDOR_ID_HAPP, USB_DEVICE_ID_UGCI_DRIVING), HID_QUIRK_BADPAD | HID_QUIRK_MULTI_INPUT },
> { HID_USB_DEVICE(USB_VENDOR_ID_HAPP, USB_DEVICE_ID_UGCI_FIGHTING), HID_QUIRK_BADPAD | HID_QUIRK_MULTI_INPUT },
> { HID_USB_DEVICE(USB_VENDOR_ID_HAPP, USB_DEVICE_ID_UGCI_FLYING), HID_QUIRK_BADPAD | HID_QUIRK_MULTI_INPUT },
> --
> 2.29.1.341.ge80a0c044ae-goog
>
--
Dmitry
next prev parent reply other threads:[~2020-10-29 20:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 19:47 [PATCH] Add devices for HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE Chris Ye
2020-10-29 20:39 ` Dmitry Torokhov [this message]
2020-11-01 20:35 ` Chris Ye
-- strict thread matches above, loose matches on Subject: below --
2020-10-29 0:00 Chris Ye
2020-10-28 23:51 FirstName LastName
2020-10-29 5:41 ` Greg KH
[not found] ` <CAFFudd+7DrJ+vYZ5wQ58mei6VMkMPGCpS1d7DwZMrzM-FVKzqQ@mail.gmail.com>
2020-10-29 19:14 ` Greg KH
2020-10-29 20:04 ` Chris Ye
2020-10-30 10:48 ` Greg KH
2020-11-01 20:34 ` Chris Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029203954.GF2547185@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=alexandru.ardelean@analog.com \
--cc=broonie@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linzhao.ye@gmail.com \
--cc=lzye@google.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).