From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19B8DC55179 for ; Fri, 30 Oct 2020 14:01:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A87592083B for ; Fri, 30 Oct 2020 14:01:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AoS23AjE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726845AbgJ3OBI (ORCPT ); Fri, 30 Oct 2020 10:01:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726812AbgJ3OBB (ORCPT ); Fri, 30 Oct 2020 10:01:01 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81870C0613D2 for ; Fri, 30 Oct 2020 07:01:01 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id z1so2970879plo.12 for ; Fri, 30 Oct 2020 07:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2MSAeCH3QM276fplDLnVy7fqn4yS738m2GKwo7OKqjI=; b=AoS23AjEXc9VutDc6Sicyfm/RLV0v2wlGhaN4jb1UdGMvyCa4djxbO0WZzhJG9naKX IJHdqs/WU+V5qK1JIWBk8k1ZTgE9iAW5oPi3aSG2Q0bIXUIbFBo106ART/EafHLjuW1Q get6UyUTj0oRolOCm/KMGpC33kVwv2glcw5IPY9xquatCEuYx1cN1FgP4TKwVavMy0EV AMiUOcZ3Nu+naUZngfLlB2BqeFKv9RcRTHz08X7AMn/Pc5Iqhg6S94l5/PSuFrdY1XkO PCmwNteckYpVuXZWp7FkkTPikXAKXQvBrnFDXBEZKG9m6zFNTS+m8hEQYPBTCnVEZ4VR n8KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2MSAeCH3QM276fplDLnVy7fqn4yS738m2GKwo7OKqjI=; b=G5Ln7/6MIITLHvl/a6b2Yl4Dq9nC3NHOQ/lwnpgJ4gwzibJRG7DOWmEfO+SsVLNf0B RmSGAhRFUVUXPA/kEgNxaX2T8rml8cV8MgKLd1hf2C9RoDVlnhUuWfpnSgKwc5CdUUPk +DDReTA2TV/tGC90kzbR1sRStm1gPd1AvJoufGZyMBG5ILDa3xijAZlBRlHzXA7sbykS kU9kH0YJS7Zb8cRSmZGxe2OyGMHq/PCHIXn9JJFnS7Hn1VKUmQxtcyEw55KLeFMsQHd+ RkMMKLpksL3dPqf3E1KVQlDUX78K7q7W5BsqGq2zxTL46A264hA20x5IJqwsXaSscVZZ eCZg== X-Gm-Message-State: AOAM5334HBeyzVHR/D7uSTQmU5wnLSaIQFwFo4zAKlIQPoPHJcKhRgCV lUoCX/ZPhczyCI22PgBOWLb4 X-Google-Smtp-Source: ABdhPJwvUhTxBXYf3P8x5mixVdH5x4naFfc0F2KhmuqfeHFEQ1aUhjl/79mviAspjEYXF0exYKOpfg== X-Received: by 2002:a17:902:788a:b029:d6:b9f:820a with SMTP id q10-20020a170902788ab02900d60b9f820amr8810013pll.76.1604066461007; Fri, 30 Oct 2020 07:01:01 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2409:4072:918:28fe:10d5:aaf5:e319:ec72]) by smtp.gmail.com with ESMTPSA id 15sm5705121pgs.52.2020.10.30.07.00.57 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 30 Oct 2020 07:01:00 -0700 (PDT) Date: Fri, 30 Oct 2020 19:30:54 +0530 From: Manivannan Sadhasivam To: Bhaumik Bhatt Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 07/12] bus: mhi: core: Use appropriate label in firmware load handler API Message-ID: <20201030140054.GJ3818@Mani-XPS-13-9360> References: <1604031057-32820-1-git-send-email-bbhatt@codeaurora.org> <1604031057-32820-8-git-send-email-bbhatt@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1604031057-32820-8-git-send-email-bbhatt@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2020 at 09:10:52PM -0700, Bhaumik Bhatt wrote: > Correct the "error_read" label to say "error_ready_state" as that > is the appropriate usage of the label. > > Signed-off-by: Bhaumik Bhatt Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/bus/mhi/core/boot.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/bus/mhi/core/boot.c b/drivers/bus/mhi/core/boot.c > index cec5010..6b4c51e 100644 > --- a/drivers/bus/mhi/core/boot.c > +++ b/drivers/bus/mhi/core/boot.c > @@ -494,7 +494,7 @@ void mhi_fw_load_handler(struct mhi_controller *mhi_cntrl) > > if (ret) { > dev_err(dev, "MHI did not enter READY state\n"); > - goto error_read; > + goto error_ready_state; > } > > /* Wait for the SBL event */ > @@ -505,7 +505,7 @@ void mhi_fw_load_handler(struct mhi_controller *mhi_cntrl) > > if (!ret || MHI_PM_IN_ERROR_STATE(mhi_cntrl->pm_state)) { > dev_err(dev, "MHI did not enter SBL\n"); > - goto error_read; > + goto error_ready_state; > } > > /* Start full firmware image download */ > @@ -521,7 +521,7 @@ void mhi_fw_load_handler(struct mhi_controller *mhi_cntrl) > > return; > > -error_read: > +error_ready_state: > mhi_free_bhie_table(mhi_cntrl, mhi_cntrl->fbc_image); > mhi_cntrl->fbc_image = NULL; > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >