linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "周琰杰 (Zhou Yanjie)" <zhouyanjie@wanyeetech.com>
Cc: dongsheng.qiu@ingenic.com, rick.tyliu@ingenic.com,
	robh+dt@kernel.org, sernia.zhou@foxmail.com,
	aric.pzqi@ingenic.com, yanfei.li@ingenic.com,
	zhenwenjin@gmail.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org
Subject: Re: [PATCH v3 1/1] dt-bindings: timer: Add new OST support for the upcoming new driver.
Date: Fri, 30 Oct 2020 13:45:15 -0500	[thread overview]
Message-ID: <20201030184515.GA4129054@bogus> (raw)
In-Reply-To: <20201026155842.10196-2-zhouyanjie@wanyeetech.com>

On Mon, 26 Oct 2020 23:58:42 +0800, 周琰杰 (Zhou Yanjie) wrote:
> The new OST has one global timer and two or four percpu timers, so there
> will be three combinations in the upcoming new OST driver: the original
> GLOBAL_TIMER + PERCPU_TIMER, the new GLOBAL_TIMER + PERCPU_TIMER0/1 and
> GLOBAL_TIMER + PERCPU_TIMER0/1/2/3, For this, add the macro definition
> about OST_CLK_PERCPU_TIMER0/1/2/3. And in order to ensure that all the
> combinations work normally, the original ABI values of OST_CLK_PERCPU_TIMER
> and OST_CLK_GLOBAL_TIMER need to be exchanged to ensure that in any
> combinations, the clock can be registered (by calling clk_hw_register())
> from index 0.
> 
> Before this patch, OST_CLK_PERCPU_TIMER and OST_CLK_GLOBAL_TIMER are only
> used in two places, one is when using "assigned-clocks" to configure the
> clocks in the DTS file; the other is when registering the clocks in the
> sysost driver. When the values of these two ABIs are exchanged, the ABI
> value used by sysost driver when registering the clock, and the ABI value
> used by DTS when configuring the clock using "assigned-clocks" will also
> change accordingly. Therefore, there is no situation that causes the wrong
> clock to the configured. Therefore, exchanging ABI values will not cause
> errors in the existing codes when registering and configuring the clocks.
> 
> Currently, in the mainline, only X1000 and X1830 are using sysost driver,
> and the upcoming X2000 will also use sysost driver. This patch has been
> tested on all three SoCs and all works fine.
> 
> Tested-by: 周正 (Zhou Zheng) <sernia.zhou@foxmail.com>
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> ---
> 
> Notes:
>     v1->v2:
>     Rewrite the commit message so that each line is less than 80 characters.
> 
>     v2->v3:
>     Add the description of why the exchange of ABI values will not affect
>     the existing driver into the commit message.
> 
>  include/dt-bindings/clock/ingenic,sysost.h | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

  reply	other threads:[~2020-10-30 18:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 15:58 [PATCH v3 0/1] Add macro definition for the upcoming new OST driver 周琰杰 (Zhou Yanjie)
2020-10-26 15:58 ` [PATCH v3 1/1] dt-bindings: timer: Add new OST support for the upcoming new driver 周琰杰 (Zhou Yanjie)
2020-10-30 18:45   ` Rob Herring [this message]
2020-12-03 23:47   ` [tip: timers/core] " tip-bot2 for 周琰杰

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201030184515.GA4129054@bogus \
    --to=robh@kernel.org \
    --cc=aric.pzqi@ingenic.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dongsheng.qiu@ingenic.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rick.tyliu@ingenic.com \
    --cc=robh+dt@kernel.org \
    --cc=sernia.zhou@foxmail.com \
    --cc=yanfei.li@ingenic.com \
    --cc=zhenwenjin@gmail.com \
    --cc=zhouyanjie@wanyeetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).