From: "Ondřej Jirman" <megous@megous.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Corentin Labbe <clabbe.montjoie@gmail.com>,
mripard@kernel.org, wens@csie.org, broonie@kernel.org,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [BUG] Error applying setting, reverse things back on lot of devices
Date: Sun, 1 Nov 2020 02:31:15 +0100 [thread overview]
Message-ID: <20201101013115.espxyxbnqgj3j4tg@core.my.home> (raw)
In-Reply-To: <20201024115307.GA2745@qmqm.qmqm.pl>
Hello Michał,
On Sat, Oct 24, 2020 at 01:53:07PM +0200, Michał Mirosław wrote:
> On Fri, Oct 23, 2020 at 10:39:43PM +0200, Corentin Labbe wrote:
> > On Fri, Oct 23, 2020 at 03:42:01PM +0200, Corentin Labbe wrote:
> > > On Wed, Oct 21, 2020 at 08:31:49PM +0200, Corentin Labbe wrote:
> > > > [ 5.796585] dcdc4: supplied by regulator-dummy
> > > > [ 5.801647] vcc-dram: supplied by regulator-dummy
> > > > [ 5.806470] vcc-gmac-phy: failed to get the current voltage: -EINVAL
> > > > [ 5.812839] axp20x-regulator axp20x-regulator: Failed to register dc1sw
> > > > [ 5.820291] axp20x-regulator: probe of axp20x-regulator failed with error -22
> > >
> > > I have just saw thoses 3 lines which are probably the real problem.
> > > I have started a new bisect with this error, but it is hitting the same "crash range" the first one.
> > >
> >
> > I have bisected the problem to commit aea6cb99703e17019e025aa71643b4d3e0a24413 ("regulator: resolve supply after creating regulator")
> > Reverting this fix my problem.
>
> Can you try the hack below?
>
> Best Regards,
> Michał Mirosław
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index a4ffd71696da..9ad091f5f1ab 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -1169,6 +1169,9 @@ static int machine_constraints_voltage(struct regulator_dev *rdev,
> }
>
> if (current_uV < 0) {
> + if (current_uV == -EINVAL && rdev->supply_name)
> + return -EPROBE_DEFER;
> +
> rdev_err(rdev,
> "failed to get the current voltage: %pe\n",
> ERR_PTR(current_uV));
I did hit the same problem on sun8i-a83t-tbs-a711.dts tablet.
The patch helps on top of v5.9.2, and on linus/master.
regards,
o.
next prev parent reply other threads:[~2020-11-01 1:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 18:31 [BUG] Error applying setting, reverse things back on lot of devices Corentin Labbe
2020-10-23 13:42 ` Corentin Labbe
2020-10-23 20:39 ` Corentin Labbe
2020-10-24 11:40 ` Michał Miosław
2020-10-24 11:53 ` Michał Mirosław
2020-11-01 1:31 ` Ondřej Jirman [this message]
2020-11-02 7:40 ` Corentin Labbe
2020-11-02 12:48 ` Ahmad Fatoum
2020-11-02 20:27 ` Michał Mirosław
2020-11-04 10:28 ` Ahmad Fatoum
2020-11-04 10:50 ` [Linux-stm32] " Alexandre Torgue
2020-11-05 8:47 ` Ahmad Fatoum
2020-11-05 2:57 ` Michał Mirosław
2020-11-05 9:11 ` Ahmad Fatoum
2020-11-08 17:08 ` Michał Mirosław
2020-11-10 10:57 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201101013115.espxyxbnqgj3j4tg@core.my.home \
--to=megous@megous.com \
--cc=broonie@kernel.org \
--cc=clabbe.montjoie@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mripard@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).