* [PATCH] asm-generic: barrier.h: fix ALPHA builds when SMP is not enabled
@ 2020-11-01 3:01 Randy Dunlap
0 siblings, 0 replies; only message in thread
From: Randy Dunlap @ 2020-11-01 3:01 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, David Howells, Arnd Bergmann,
Richard Henderson, Ivan Kokshaysky, Matt Turner, linux-alpha
<asm-generic/barrier.h> uses barrier() but needs to #include
<linux/compiler.h> to get a generic definition of it to fix
build errors in arch/alpha/ builds when CONFIG_SMP is not enabled.
Fixes build errors like this (there are several like this):
[49 in the kernel config that was supplied by the 0day bot]
In file included from ../arch/alpha/include/asm/barrier.h:21,
from ../arch/alpha/include/asm/atomic.h:6,
from ../include/linux/atomic.h:7,
from ../include/linux/dcache.h:5,
from ../fs/proc/util.c:1:
../arch/alpha/include/asm/atomic.h: In function 'atomic_add_return_relaxed':
../include/asm-generic/barrier.h:78:18: error: implicit declaration of function 'barrier' [-Werror=implicit-function-declaration]
78 | #define smp_mb() barrier()
| ^~~~~~~
Fixes: 885df91ca357 ("Create asm-generic/barrier.h")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Matt Turner <mattst88@gmail.com>
Cc: linux-alpha@vger.kernel.org
---
include/asm-generic/barrier.h | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20201030.orig/include/asm-generic/barrier.h
+++ linux-next-20201030/include/asm-generic/barrier.h
@@ -13,6 +13,7 @@
#ifndef __ASSEMBLY__
+#include <linux/compiler.h>
#include <asm/rwonce.h>
#ifndef nop
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-11-01 3:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-01 3:01 [PATCH] asm-generic: barrier.h: fix ALPHA builds when SMP is not enabled Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).