From: Sudeep Holla <sudeep.holla@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Cristian Marussi <cristian.marussi@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
lukasz.luba@arm.com, james.quinlan@broadcom.com,
Jonathan.Cameron@Huawei.com, satyakim@qti.qualcomm.com,
etienne.carriere@linaro.org, f.fainelli@gmail.com,
vincent.guittot@linaro.org, Sudeep Holla <sudeep.holla@arm.com>,
souvik.chakravarty@arm.com
Subject: Re: [PATCH v3 4/4] dt-bindings: arm: add support for SCMI Regulators
Date: Mon, 2 Nov 2020 09:01:20 +0000 [thread overview]
Message-ID: <20201102090120.xb7ghg6kfh3unisr@bogus> (raw)
In-Reply-To: <20201030190606.GL4405@sirena.org.uk>
On Fri, Oct 30, 2020 at 07:06:07PM +0000, Mark Brown wrote:
> On Fri, Oct 30, 2020 at 01:55:14PM -0500, Rob Herring wrote:
>
> > I'm a bit worried that now we're changing CPUs (at least?) from clocks
> > to 'performance domains' while at the same time here we're adding
> > low level, virtual regulators. Are we going to end up wanting something
> > more abstract here too?
Valid concern and I too am with the same opinion. However as Mark Brown
points out this was added to just satisfy some exiting consumers that
rely on regulators.
I had or still argue that we need a way to check if this is not getting
misused with devices like CPUs. I was thinking of some check with DT where
such properties are not allowed in certain device type.
>
> My understanding is that this is aimed at systems which have done the
> more abstract thing where regulators just aren't visible at all to the
> kernel but then find that they actually need to control some of the
> regulators explicitly for things like MMC so need a mechanism for the
> firmware to expose select regulators.
Thanks Mark for the explaining this, saved me time 😄.
--
Regards,
Sudeep
next prev parent reply other threads:[~2020-11-02 9:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 20:31 [PATCH v3 0/4] Add support for SCMIv3.0 Voltage Domain Protocol and SCMI-Regulator Cristian Marussi
2020-10-26 20:31 ` [PATCH v3 1/4] firmware: arm_scmi: Add Voltage Domain Support Cristian Marussi
2020-10-27 6:04 ` kernel test robot
2020-10-27 11:07 ` Cristian Marussi
2020-10-27 6:04 ` [PATCH] firmware: arm_scmi: fix noderef.cocci warnings kernel test robot
2020-10-28 14:29 ` [PATCH v3 1/4] firmware: arm_scmi: Add Voltage Domain Support Etienne Carriere
2020-10-28 20:44 ` Cristian Marussi
2020-10-29 11:21 ` Etienne Carriere
2020-10-29 11:44 ` Cristian Marussi
2020-10-26 20:31 ` [PATCH v3 2/4] firmware: arm_scmi: add SCMI Voltage Domain devname Cristian Marussi
2020-10-26 20:31 ` [PATCH v3 3/4] regulator: add SCMI driver Cristian Marussi
2020-10-26 20:31 ` [PATCH v3 4/4] dt-bindings: arm: add support for SCMI Regulators Cristian Marussi
2020-10-30 18:55 ` Rob Herring
2020-10-30 19:06 ` Mark Brown
2020-11-02 9:01 ` Sudeep Holla [this message]
2020-11-02 9:27 ` Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102090120.xb7ghg6kfh3unisr@bogus \
--to=sudeep.holla@arm.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=broonie@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=etienne.carriere@linaro.org \
--cc=f.fainelli@gmail.com \
--cc=james.quinlan@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=robh@kernel.org \
--cc=satyakim@qti.qualcomm.com \
--cc=souvik.chakravarty@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).