From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3302CC00A89 for ; Mon, 2 Nov 2020 10:25:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D904F2071E for ; Mon, 2 Nov 2020 10:25:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728491AbgKBKZd (ORCPT ); Mon, 2 Nov 2020 05:25:33 -0500 Received: from leonov.paulk.fr ([185.233.101.22]:56318 "EHLO leonov.paulk.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728005AbgKBKZc (ORCPT ); Mon, 2 Nov 2020 05:25:32 -0500 Received: from gagarine.paulk.fr (gagarine [192.168.1.127]) by leonov.paulk.fr (Postfix) with ESMTPS id B79A4C0121; Mon, 2 Nov 2020 11:25:28 +0100 (CET) Received: by gagarine.paulk.fr (Postfix, from userid 114) id 048E3C1D6F; Mon, 2 Nov 2020 11:25:27 +0100 (CET) Received: from aptenodytes (unknown [192.168.1.1]) by gagarine.paulk.fr (Postfix) with ESMTPSA id 220ACC1D6C; Mon, 2 Nov 2020 11:25:23 +0100 (CET) Date: Mon, 2 Nov 2020 11:25:22 +0100 From: Paul Kocialkowski To: Maxime Ripard Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Chen-Yu Tsai , Matteo Scordino , Icenowy Zheng Subject: Re: [PATCH 6/9] ARM: dts: sun8i-v3s: Add the V3s NMI IRQ controller Message-ID: <20201102102522.GB11809@aptenodytes> References: <20201031182137.1879521-1-contact@paulk.fr> <20201031182137.1879521-7-contact@paulk.fr> <20201102101211.wtkmgfm2rcm5gdyp@gilmour.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201102101211.wtkmgfm2rcm5gdyp@gilmour.lan> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon 02 Nov 20, 11:12, Maxime Ripard wrote: > On Sat, Oct 31, 2020 at 07:21:34PM +0100, Paul Kocialkowski wrote: > > The V3s/V3 has a NMI interrupt controller, mainly used for the AXP209. > > Its address follows the sytsem controller block, which was previously > > incorrectly described as spanning over 0x1000 address bytes. > > Is it after, or right in the middle of it? That's up for interpretation actually: - The V3 datasheet mentions that System Control is 0x01C00000 --- 0x01C00FFF; - In practice, sunxi_sram.c uses a regmap with max_reg set to 0x30 for the V3s/H3 so this gives us some room. Looking at other SoCs with the same setup (take sun8i-r40 for instance), system-control is limited to 0x30 and the NMI controller follows it. In the case of R40, the SRAM controlled is also said to be 4K-long in the Allwinner docs. So all in all, this leads me to believe that the system-controller instance stops well before 0x1c000d0 on the V3s as well. Otherwise, we should also make the R40 consistent. Cheers, Paul -- Developer of free digital technology and hardware support. Website: https://www.paulk.fr/ Coding blog: https://code.paulk.fr/ Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/