From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43FD4C00A89 for ; Tue, 3 Nov 2020 00:19:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E11CC22275 for ; Tue, 3 Nov 2020 00:19:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604362787; bh=rLRezgozMo36bMQEdpj1d95Jvx+If6mlRaMG5lcBdrs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=BEVsjcjpwTOeQX9f+Tf0wPOArU9w6bjQJrTkZKnIjMFrg4IH5KPDkFTPniw0ld8Wr gIoELBEvv+7Jo4sd2xM6N9DEYsEEVs9abbnX2qi/juY1L4svEJn1yrcNbti+sq+1eY +EppkPWwnEUqLjp5aTLoMgS4J40yrGFvJYZkzq2I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727270AbgKCATq (ORCPT ); Mon, 2 Nov 2020 19:19:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:40344 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725940AbgKCATp (ORCPT ); Mon, 2 Nov 2020 19:19:45 -0500 Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7C1042225E; Tue, 3 Nov 2020 00:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604362784; bh=rLRezgozMo36bMQEdpj1d95Jvx+If6mlRaMG5lcBdrs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MbvkXAq0VUXFsJuj2ZnX3LnowoI1qdCl/SgPBttkyxSaq4tckfVjdJVL1M41GarSN vmkquE8NaEmjduVpMqy3/P6P3NU/G5T5EYfBw154R86gBXSzSKUFmEyW/tZ0sG75DF wzIuIV2kQzVd3re/LNYLmrx8CWw9OLaXcYZGonAw= Date: Mon, 2 Nov 2020 16:19:43 -0800 From: Jakub Kicinski To: Paul Menzel Cc: Jesse Brandeburg , Tony Nguyen , Jeffrey Townsend , "David S . Miller" , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, John W Linville Subject: Re: [PATCH 2/2] ethernet: igb: e1000_phy: Check for ops.force_speed_duplex existence Message-ID: <20201102161943.343586b1@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20201102231307.13021-3-pmenzel@molgen.mpg.de> References: <20201102231307.13021-1-pmenzel@molgen.mpg.de> <20201102231307.13021-3-pmenzel@molgen.mpg.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 3 Nov 2020 00:13:07 +0100 Paul Menzel wrote: > From: Jeffrey Townsend > > The ops field might no be defined, so add a check. This change should be first, otherwise AFAIU if someone builds the kernel in between the commits (e.g. for bisection) it will crash. > The patch is taken from Open Network Linux (ONL), and it was added there > as part of the patch > > packages/base/any/kernels/3.16+deb8/patches/driver-support-intel-igb-bcm5461X-phy.patch > > in ONL commit f32316c63c (Support the BCM54616 and BCM5461S.) [1]. Part > of this commit was already upstreamed in Linux commit eeb0149660 (igb: > support BCM54616 PHY) in 2017. > > I applied the forward-ported > > packages/base/any/kernels/5.4-lts/patches/0002-driver-support-intel-igb-bcm5461S-phy.patch > > added in ONL commit 5ace6bcdb3 (Add 5.4 LTS kernel build.) [2]. > > [1]: https://github.com/opencomputeproject/OpenNetworkLinux/commit/f32316c63ce3a64de125b7429115c6d45e942bd1 > [2]: https://github.com/opencomputeproject/OpenNetworkLinux/commit/5ace6bcdb37cb8065dcd1d4404b3dcb6424f6331 No need to put this in every commit message. We preserve the cover letter in tree as a merge commit message, so explaining things once in the cover letter is sufficient. > Cc: Jeffrey Townsend Jefferey will need to provide a sign-off as the author. > Cc: John W Linville > Signed-off-by: Paul Menzel