From: Sargun Dhillon <sargun@sargun.me>
To: "J . Bruce Fields" <bfields@fieldses.org>,
Chuck Lever <chuck.lever@oracle.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
Anna Schumaker <schumaker.anna@gmail.com>,
David Howells <dhowells@redhat.com>,
Scott Mayhew <smayhew@redhat.com>
Cc: Sargun Dhillon <sargun@sargun.me>,
linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/2] NFS: Fix interaction between fs_context and user namespaces
Date: Mon, 2 Nov 2020 09:47:35 -0800 [thread overview]
Message-ID: <20201102174737.2740-1-sargun@sargun.me> (raw)
This is effectively a resend, but re-based atop Anna's current tree. I can
add the samples back in an another patchset.
Right now, it is possible to mount NFS with an non-matching super block
user ns, and NFS sunrpc user ns. This (for the user) results in an awkward
set of interactions if using anything other than auth_null, where the UIDs
being sent to the server are different than the local UIDs being checked.
This can cause "breakage", where if you try to communicate with the NFS
server with any other set of mappings, it breaks.
This is after the initial v5.10 merge window, so hopefully this patchset
can be reconsidered, and maybe we can make forward progress? I think that
it takes a relatively conservative approach in enabling user namespaces,
and it prevents the case where someone is using auth_gss (for now), as the
mappings are non-trivial.
Changes since v3:
* Rebase atop Anna's tree
Changes since v2:
* Removed samples
* Split out NFSv2/v3 patchset from NFSv4 patchset
* Added restrictions around use
Changes since v1:
* Added samples
Sargun Dhillon (2):
NFS: NFSv2/NFSv3: Use cred from fs_context during mount
NFSv4: Refactor NFS to use user namespaces
fs/nfs/client.c | 10 ++++++++--
fs/nfs/nfs4client.c | 27 ++++++++++++++++++++++++++-
fs/nfs/nfs4idmap.c | 2 +-
fs/nfs/nfs4idmap.h | 3 ++-
4 files changed, 37 insertions(+), 5 deletions(-)
base-commit: 8c39076c276be0b31982e44654e2c2357473258a
--
2.25.1
next reply other threads:[~2020-11-02 17:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 17:47 Sargun Dhillon [this message]
2020-11-02 17:47 ` [PATCH v4 1/2] NFS: NFSv2/NFSv3: Use cred from fs_context during mount Sargun Dhillon
2020-11-02 17:47 ` [PATCH v4 2/2] NFSv4: Refactor NFS to use user namespaces Sargun Dhillon
2020-11-10 16:43 ` [PATCH v4 0/2] NFS: Fix interaction between fs_context and " Alban Crequy
2020-11-10 20:12 ` Trond Myklebust
2020-11-11 11:12 ` Sargun Dhillon
2020-11-11 14:38 ` Trond Myklebust
2020-11-11 18:57 ` Sargun Dhillon
2020-11-11 20:03 ` Trond Myklebust
2020-11-12 0:30 ` Sargun Dhillon
2020-11-12 0:42 ` Sargun Dhillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102174737.2740-1-sargun@sargun.me \
--to=sargun@sargun.me \
--cc=anna.schumaker@netapp.com \
--cc=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=schumaker.anna@gmail.com \
--cc=smayhew@redhat.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).