From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0FE6C00A89 for ; Mon, 2 Nov 2020 20:48:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52FA2205F4 for ; Mon, 2 Nov 2020 20:48:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="AooKG3JK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727079AbgKBUsU (ORCPT ); Mon, 2 Nov 2020 15:48:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726784AbgKBUrx (ORCPT ); Mon, 2 Nov 2020 15:47:53 -0500 Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EBC4C061A04 for ; Mon, 2 Nov 2020 12:47:53 -0800 (PST) Received: by mail-qt1-x842.google.com with SMTP id f93so10161459qtb.10 for ; Mon, 02 Nov 2020 12:47:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Nj7sBGiH3baY4a625q23mk4W+OwP4KOftkycQT8zu4o=; b=AooKG3JKnOmiHLh9nY54aYGlYs4PzFJ7MlNomW/8sYein7Vt3XnigPfayRPJcNRlrK ZBsuA/Hs9q+xHuwYyIZ0ExR0cE7+VVHZt8+QOG35Oru++TKZNJidpX/UuW05lxc4lHm1 ehdA1V95yP0ap2IzhmgDjDrWwUq0Ay+RBeA8L3zPBLBnKSdRN/CPrpWYwOpaPZv6oo+1 mJE7W5YL4VmmnXWJyxus2MHR2GjslNtuUQXItA05LBYMYAjYwNRjR8WGILXmQjuPsLFf tcxxfAY6lCD5wxFXijlzYwfHi+fE43euh1dwJzyDic0uGeDgD+zdvpLKx1MwijGOuhsd brUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Nj7sBGiH3baY4a625q23mk4W+OwP4KOftkycQT8zu4o=; b=PiQ2MCWkZa5EJ/XxB8oGy6x+NMV25EfWxz1+g+ar8bO0CBKYZVg5jg4oqlrNTfgksb ZC3t4b2nUN7bj+eJVPnwbMJmqx76li/ypRUxLjZ2zc1e9ptIZNZW9DT/KkoxtVP0HKbf Z0I0QoW6JkRggkOptoX1Eyui9GOVKWB/08gatJzYv3PwsyWqQiuQSbZ2ookWktBD0gSL ZjFik9Ph5+5INl9o2UA2c7F/nvQGvARXS1xzxHo52C24HiS1gcQCJFLJOZaT1BhHpzm2 x/4KSuBCmTxDM+dsmTJMEs/PHNCuFi+Pgs6OAUyZSAKx6YsvnpE+ZgKIAX6UPHpBuKnN xCZg== X-Gm-Message-State: AOAM530n7Ml9hORRMZfHmnnA71hs7byBou+QrECQfl9cqGXYyqi0mzyI uO0sAaerVgsbi5ReDIOSV1o+Hg== X-Google-Smtp-Source: ABdhPJwUqPE8UL+goivCuxPOedpZNc1PpHve+Wa7sHmVXfIF4vDKOnoQRO2PB2LDNWng556UnGVtYA== X-Received: by 2002:ac8:4f06:: with SMTP id b6mr16800372qte.163.1604350072520; Mon, 02 Nov 2020 12:47:52 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:2f6e]) by smtp.gmail.com with ESMTPSA id x22sm7963711qkn.125.2020.11.02.12.47.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 12:47:51 -0800 (PST) Date: Mon, 2 Nov 2020 15:46:07 -0500 From: Johannes Weiner To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com, Andrey Ryabinin , Jann Horn Subject: Re: [PATCH v20 20/20] mm/lru: revise the comments of lru_lock Message-ID: <20201102204607.GD740958@cmpxchg.org> References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-21-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1603968305-8026-21-git-send-email-alex.shi@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2020 at 06:45:05PM +0800, Alex Shi wrote: > From: Hugh Dickins > > Since we changed the pgdat->lru_lock to lruvec->lru_lock, it's time to > fix the incorrect comments in code. Also fixed some zone->lru_lock comment > error from ancient time. etc. > > I struggled to understand the comment above move_pages_to_lru() (surely > it never calls page_referenced()), and eventually realized that most of > it had got separated from shrink_active_list(): move that comment back. > > Signed-off-by: Hugh Dickins > Signed-off-by: Alex Shi > Cc: Andrew Morton > Cc: Tejun Heo > Cc: Andrey Ryabinin > Cc: Jann Horn > Cc: Mel Gorman > Cc: Johannes Weiner > Cc: Matthew Wilcox > Cc: Hugh Dickins > Cc: cgroups@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-mm@kvack.org Acked-by: Johannes Weiner